Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation generation #1715

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix documentation generation #1715

merged 1 commit into from
Mar 4, 2024

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Mar 1, 2024

Fixes #1711.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch baentsch marked this pull request as ready for review March 4, 2024 08:07
@baentsch baentsch requested a review from dstebila as a code owner March 4, 2024 08:07
@baentsch
Copy link
Member Author

baentsch commented Mar 4, 2024

This PR does not impact the Travis files, so I'm assuming that stuff if broken asking for someone more knowledgeable regarding those platforms to take a look (@bhess?).

@baentsch
Copy link
Member Author

baentsch commented Mar 4, 2024

asking for someone more knowledgeable

disregard. Travis passes after requesting a re-run.

Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not impact the Travis files, so I'm assuming that stuff if broken asking for someone more knowledgeable regarding those platforms to take a look (@bhess?).

Seems there was a glitch with Travis, I've re-run it and it works now.

@baentsch baentsch merged commit bdce954 into main Mar 4, 2024
76 checks passed
@baentsch baentsch deleted the mb-fixdocumentation branch March 4, 2024 14:11
@bhess
Copy link
Member

bhess commented Mar 4, 2024

Looks like Travis errored again after the merge, I've created a ticket with them about the issue.

Eddy-M-K pushed a commit to Eddy-M-K/liboqs that referenced this pull request Apr 5, 2024
Signed-off-by: Eddy Kim <Eddy.M.Kim@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation fails to build corrrectly
3 participants