Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X.509 implementation using composite keys and sigs drafts #333

Closed
dstebila opened this issue Sep 30, 2021 · 4 comments
Closed

Add X.509 implementation using composite keys and sigs drafts #333

dstebila opened this issue Sep 30, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@dstebila dstebila added the enhancement New feature or request label Sep 30, 2021
@christianpaquin
Copy link

Didn't we discuss prototyping the various hybrid approaches concurrently? I'd recommend doing this work in a separate branch, and not simply replace our current concatenation approach.

@baentsch
Copy link
Member

baentsch commented Oct 1, 2021

I'd also second @christianpaquin maybe proposing as a compromise using the term "Add" instead of "Migrate" in this issue: Having both approaches (switchable by some means, e.g., environment variable) in one implementation/branch might be doable.

Reason from my side against dumping the current approach: A stable OQS-OSSL code base to establish interop with oqs-provider (currently working through open-quantum-safe/oqs-provider#2) would be better than changing this logic in two places at the same time. Also, this work already creates challenges (at least for me) as the OSSL3 provider API and OSSL X509 APIs are not yet perfectly in tune for external (provider) use. After a cursory glance at it this RFC might actually be more simple to implement with a completely new X509 code base only using the ASN.1 APIs rather than patching things...

@dstebila
Copy link
Member Author

dstebila commented Oct 5, 2021

Good point re: trying in a separate branch for now. I didn't think too careful about the choice of word "migrate"; I'll change it to "Add".

@dstebila dstebila changed the title Migrate X.509 to composite keys and sigs drafts Add X.509 implementation using composite keys and sigs drafts Oct 5, 2021
@dstebila
Copy link
Member Author

My understanding is that they're revisiting their approach, so there may be new drafts with different designs. Closing this until a clearer path forward emerges.

@dstebila dstebila closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants