Full hybrid support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybrid sig keygen added adding classic sig length complete hybrid sig support
bhess
requested changes
Nov 10, 2021
oqs-template/oqsprov/oqs_decode_der2key.c/decoder_make.fragment
Outdated
Show resolved
Hide resolved
bhess
reviewed
Nov 10, 2021
bhess
approved these changes
Nov 11, 2021
This was referenced Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 :
Fixes #6 :
Fixes #7 :
@bhess: Please note the changes as to how classic key/sig lengths get stored in the
privkeyandpubkeystructures and how thecomp_*keys are being used: There are some slight semantics changes aimed at re-using and retaining (most of) the hybrid KEM logic you added while also marshalling data for encoding (and consequent decoding).@dstebila For now this code maintains & tests full interoperability with oqs-openssl. Once this code gets merged, my concern raised here is dropped and we could begin implementing open-quantum-safe/openssl#333 (and/or #39)