Fixes oqs nid table indexing #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coded the defined nids to satisfy dependent code assumptions.
|
@dstebila, integration tests should be run on this branch before merging, to make sure I didn't break one config set. |
|
Integration tests triggered on https://github.com/open-quantum-safe/testing/commits/openssl-83. (I've also made an issue #84 to move integration tests over to the OpenSSL repository so that they will get triggered automatically.) |
dstebila
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing algs (removed in PR #82) in the oqs nid table to avoid index gaps, and hardcoded the defined nids to satisfy dependent code assumptions.