Fixed regression due to PQClean round 2 NewHope #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get a seg fault when trying the |
|
That's interesting, the exchange (run on macOS) works fine for me. Perhaps further modifications to the build scripts might be required to account for this. |
|
@christianpaquin Are you able to provide information on reproducing? I can't make the segfault on my tests and the PR is passing CircleCI. I'd like to get this merged quickly since other people are running into this bug. |
|
Might be a quirk on my system; you can merge for now and I'll investigate later. |
Closed
dstebila
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the regression introduced by this commit: open-quantum-safe/liboqs@16ea923, and also adds a Circle CI workflow that should run all the jobs every night.