Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common.py #173

Closed
wants to merge 1 commit into from
Closed

Common.py #173

wants to merge 1 commit into from

Conversation

bhess
Copy link
Member

@bhess bhess commented May 28, 2023

Adds common.py, similar to the version in oqs-openssl (https://github.com/open-quantum-safe/openssl/blob/OQS-OpenSSL_1_1_1-stable/oqs-test/common.py).

In addition, adds the security levels to each sig and kex algorithm.

Used by the build script for the test server.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to use jinja2 here? Why not use the normal OpenSSL mechanisms for this (list -signature-algorithms|-kem-algorithms)?

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which software needs this script (other than oqs-demos/nginx)? Right now, I tend to not see value in having/maintaining this in this repo, but I'm open to proposals...

@bhess
Copy link
Member Author

bhess commented May 29, 2023

Ok for me to close this PR. As discussed in open-quantum-safe/oqs-demos#204, using openssl list seems the better way for oqs-demos to get the same information.

@baentsch baentsch closed this May 29, 2023
@baentsch baentsch deleted the bhe-serverupd branch June 9, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants