Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .DS_Store (macOS), .vscode (visual studio code), and .idea (Jetbr… #200

Merged
merged 1 commit into from Jun 30, 2023

Conversation

planetf1
Copy link
Contributor

…ains IDE) to .gitignore

Adds common filetypes to .gitignore, so that developers don't accidentally checkin files that are
typically modified locally.

.vscode -- this is used to store Microsoft Visual Studio code workspace information
.idea - this is used by Jetbrains IDEs like CLion (or IntelliJ)
.DS_Store - this stores additional attributes on macOS

In my case I was experimenting with building the provider for the first time, and was trying out the two IDEs, and
noticed these modifications, so it seemed appropriate to clean them up.

@planetf1 planetf1 requested a review from baentsch as a code owner June 29, 2023 14:59
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution -- the .gitignore changes are a good addition. All other files are not: Please remove them from the PR.

@planetf1
Copy link
Contributor Author

Apologies. A rogue rebase before pr. My error. Will redo

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
@planetf1
Copy link
Contributor Author

Fixed bad commit.

@baentsch baentsch merged commit aff8a30 into open-quantum-safe:main Jun 30, 2023
10 checks passed
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
…safe#200)

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants