adding contributing guideline [skip ci] #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @baentsch, thanks for following up here. The only hiccup I had in PR #188 was diagnosing CI failures, as CircleCI doesn't show failed test output (at least not to non-maintainers such as myself). Perhaps a sentence or two explaining how to run the tests locally would help newcomers diagnose their own issues before publishing a draft PR. Similarly, many projects I've seen have a DEVELOPMENT.md file explaining common workflows in the build/dev/test cycle. |
dstebila
approved these changes
Sep 21, 2023
|
Thanks @WillChilds-Klein for the suggestions. Please check out the latest additions to the PR and let me know if/where you'd see obvious further room for improvement. |
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 13, 2024
* adding contributing guideline * adding further dev support information Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
* adding contributing guideline * adding further dev support information Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
* adding contributing guideline * adding further dev support information
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* adding contributing guideline * adding further dev support information Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* adding contributing guideline * adding further dev support information Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* adding contributing guideline * adding further dev support information Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding final item missing to complete https://github.com/open-quantum-safe/oqs-provider/community.
Feedback/suggestions for improvements particularly solicited from the most recent new contributors @thb-sb @marcbrevoort-cyberhive @WillChilds-Klein @alexzas: What information would help (have helped you :) most if documented?