Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 20240410 minutes #18

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

planetf1
Copy link
Contributor

Adds an initial version of the minutes from 2024-04-10

@ryjones @dstebila can you point me to/share the meeting recording/transcript & I'll update with any omissions.

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
@planetf1
Copy link
Contributor Author

Thanks. I'll do the next iteration in next day.

Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
@planetf1
Copy link
Contributor Author

I've made a few small changes, including adding the recording
Moving out of draft - these are ready for review now.

@planetf1 planetf1 marked this pull request as ready for review April 16, 2024 10:20
@ryjones ryjones requested review from dstebila and a team April 17, 2024 16:12
@planetf1
Copy link
Contributor Author

Do we merge when the TSC approves in the next call, or merge before that, with the approval still occuring in the meeting?

@ryjones
Copy link
Contributor

ryjones commented Apr 18, 2024

@planetf1 I would think the TSC members mark it as approved, and merge once you reach the level required?

@baentsch
Copy link
Member

@planetf1 I would think the TSC members mark it as approved, and merge once you reach the level required?

@ryjones @planetf1 the "OQS culture" so far was that PRs don't get merged with questions at least given feedback.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for feedback/clarifications (whether I understood things right) on 3 line items.

meetings/2024-04-10/minutes.md Show resolved Hide resolved
meetings/2024-04-10/minutes.md Show resolved Hide resolved
meetings/2024-04-10/minutes.md Show resolved Hide resolved
@planetf1
Copy link
Contributor Author

@planetf1 I would think the TSC members mark it as approved, and merge once you reach the level required?

@ryjones @planetf1 the "OQS culture" so far was that PRs don't get merged with questions at least given feedback.

In previous projects we've enforced that conversations are closed before merging - agree.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @planetf1 . Conversations marked as resolved.

@dstebila dstebila merged commit c40ddf3 into open-quantum-safe:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants