Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error instead of termination #7

Closed
Michael-E-Rose opened this issue Apr 8, 2020 · 1 comment
Closed

Error instead of termination #7

Michael-E-Rose opened this issue Apr 8, 2020 · 1 comment
Assignees

Comments

@Michael-E-Rose
Copy link
Contributor

If input criteria are not of the expected form (such as that the input is not a numpy array), the object throws a message and then terminates the execution. Neither is standard or desirable. Instead, the object should throw an exception (probably AttributeError) and nothing else.

@open-risk open-risk self-assigned this Apr 8, 2020
@open-risk
Copy link
Owner

type and value checking has been streamlined. more in-depth testing will likely come in the future (after a new round of index additions and a likely api redesign)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants