-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example deployment #290
example deployment #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
||
others: | ||
* kubernetes | ||
* minikube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check (maybe for the future), and maybe I'm wrong, but since we will also want to use Fluentd and use it in an air-gapped closed env, isn't something like rancher a better fit for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome documentation btw. I'll try to test it tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, rancher will be better in general. I used minikube because it is the only "quick k8s" solution I have experience with.
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 81.58% 81.41% -0.17%
==========================================
Files 135 135
Lines 3231 3213 -18
Branches 449 449
==========================================
- Hits 2636 2616 -20
- Misses 487 489 +2
Partials 108 108
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…es not validate cache correctly Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
looks great so far! 🤯 |
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
What's new
This adds an example deployment that can be used in an airgapped network.
Best description is to take a look at the README https://github.com/open-rmf/rmf-web/tree/example-deployment/example-deployment.
Self-checks
Discussion