Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example deployment #290

Merged
merged 13 commits into from
Mar 30, 2021
Merged

example deployment #290

merged 13 commits into from
Mar 30, 2021

Conversation

koonpeng
Copy link
Collaborator

@koonpeng koonpeng commented Mar 24, 2021

What's new

This adds an example deployment that can be used in an airgapped network.

Best description is to take a look at the README https://github.com/open-rmf/rmf-web/tree/example-deployment/example-deployment.

Self-checks

  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

wip
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@koonpeng koonpeng marked this pull request as draft March 24, 2021 10:33
Copy link
Collaborator

@matiasbavera matiasbavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


others:
* kubernetes
* minikube
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check (maybe for the future), and maybe I'm wrong, but since we will also want to use Fluentd and use it in an air-gapped closed env, isn't something like rancher a better fit for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome documentation btw. I'll try to test it tomorrow

Copy link
Collaborator Author

@koonpeng koonpeng Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, rancher will be better in general. I used minikube because it is the only "quick k8s" solution I have experience with.

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@koonpeng koonpeng marked this pull request as ready for review March 25, 2021 09:51
@koonpeng koonpeng marked this pull request as draft March 25, 2021 10:38
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@koonpeng koonpeng marked this pull request as ready for review March 26, 2021 01:16
@koonpeng koonpeng added this to In Review in Research & Development via automation Mar 26, 2021
@koonpeng koonpeng linked an issue Mar 26, 2021 that may be closed by this pull request
Teo Koon Peng added 2 commits March 26, 2021 09:23
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@cnboonhan cnboonhan self-requested a review March 26, 2021 01:45
example-deployment/README.md Show resolved Hide resolved
example-deployment/README.md Show resolved Hide resolved
example-deployment/README.md Show resolved Hide resolved
example-deployment/README.md Show resolved Hide resolved
example-deployment/README.md Show resolved Hide resolved
example-deployment/README.md Show resolved Hide resolved
example-deployment/docker/builder.dockerfile Outdated Show resolved Hide resolved
example-deployment/jwt-pub-key.pub Outdated Show resolved Hide resolved
example-deployment/keycloak.pem Outdated Show resolved Hide resolved
Teo Koon Peng added 5 commits March 29, 2021 09:08
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #290 (4d85bc2) into main (6c301ab) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   81.58%   81.41%   -0.17%     
==========================================
  Files         135      135              
  Lines        3231     3213      -18     
  Branches      449      449              
==========================================
- Hits         2636     2616      -20     
- Misses        487      489       +2     
  Partials      108      108              
Flag Coverage Δ
dashboard 62.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/api-server/api_server/rmf_io/authenticator.py 85.71% <0.00%> (-6.60%) ⬇️
packages/api-server/api_server/rmf_io/rmf_io.py 95.16% <0.00%> (-2.42%) ⬇️
packages/api-server/api_server/app_config.py 95.00% <0.00%> (-0.24%) ⬇️
packages/api-server/api_server/app.py 84.25% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c301ab...4d85bc2. Read the comment docs.

Teo Koon Peng added 2 commits March 29, 2021 12:49
…es not validate cache correctly

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@cnboonhan
Copy link
Contributor

looks great so far! 🤯

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@koonpeng koonpeng merged commit fc14335 into main Mar 30, 2021
Research & Development automation moved this from In Review to Done Mar 30, 2021
@koonpeng koonpeng deleted the example-deployment branch March 30, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

document how to deploy/install Alpha 1 web backend
3 participants