Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/decommission #920

Merged
merged 41 commits into from
Apr 15, 2024
Merged

Hammer/decommission #920

merged 41 commits into from
Apr 15, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Mar 19, 2024

What's new

  • New REST endpoint and gateway to handle decommission/recommission of robots, generated using Introduce schemas for robot commission request rmf_api_msgs#48
  • Requires Stabilize commissioning feature rmf_ros2#338
  • Basic decommission button
  • Robot is considered decommissioned if dispatch_tasks and direct_tasks are false in robot_state.commission, and this will allow it to be recommissioned, otherwise, the user can request to decommission the robot
  • Choice to not re-assign queued tasks in confirmation dialog, default true
  • Choice to allow idle behaviors (finishing tasks, charging, parking, etc), default false

image

image

To Test

  • As of 11th April, sync source rmf_ros2 and rmf_api_msgs to latest main and build
  • Test with any of the demos

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…alized

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 34.85477% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 45.71%. Comparing base (fe0e808) to head (8fd1593).
Report is 76 commits behind head on deploy/hammer.

❗ Current head 8fd1593 differs from pull request most recent head 034400e. Consider uploading reports for the commit 034400e to get more accurate results

Files Patch % Lines
...board/src/components/robots/robot-decommission.tsx 0.00% 79 Missing ⚠️
...server/api_server/models/rmf_api/rtls_tag_state.py 0.00% 31 Missing ⚠️
packages/api-server/api_server/routes/fleets.py 46.93% 26 Missing ⚠️
...ver/api_server/models/rmf_api/transformation_2D.py 0.00% 9 Missing ⚠️
.../dashboard/src/components/robots/robot-summary.tsx 0.00% 6 Missing ⚠️
...ges/dashboard/src/components/robots/robots-app.tsx 0.00% 4 Missing ⚠️
...act-components/lib/robots/robot-table-datagrid.tsx 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #920      +/-   ##
=================================================
- Coverage          49.35%   45.71%   -3.65%     
=================================================
  Files                285      297      +12     
  Lines               7564     8792    +1228     
  Branches            1050     1422     +372     
=================================================
+ Hits                3733     4019     +286     
- Misses              3682     4572     +890     
- Partials             149      201      +52     
Flag Coverage Δ
api-server 75.80% <55.10%> (-4.99%) ⬇️
dashboard 13.35% <0.00%> (-1.72%) ⬇️
react-components 44.45% <60.00%> (-3.62%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…Body

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…commission

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review March 27, 2024 16:52
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
packages/api-server/api_server/routes/fleets.py Outdated Show resolved Hide resolved
packages/api-server/api_server/routes/fleets.py Outdated Show resolved Hide resolved
packages/api-server/api_server/routes/fleets.py Outdated Show resolved Hide resolved
packages/api-server/api_server/routes/fleets.py Outdated Show resolved Hide resolved
packages/react-components/lib/robots/robot-table.tsx Outdated Show resolved Hide resolved
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit e6a2eae into deploy/hammer Apr 15, 2024
5 checks passed
@aaronchongth aaronchongth deleted the hammer/decommission branch April 15, 2024 12:31
@aaronchongth aaronchongth restored the hammer/decommission branch April 15, 2024 12:35
@aaronchongth aaronchongth deleted the hammer/decommission branch April 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants