support jazzy #955

koonpeng · 2024-06-12T05:41:48Z

What's new

Update to noble+jazzy.

Build a minimal rmf image because the rmf demos image is not yet updated to jazzy, also it's huge.
Update all workflows to use that minimal image.
Update references of humble to jazzy.
Cleanup workflows.
bootstrap venv + pipenv because pip no longer allows installing to system packages in noble

Self-checks

I have prototyped this new feature (if necessary) on Figma
I'm familiar with and follow this Typescript guideline
I added unit-tests for new components
I tried testing edge cases
I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

README.md

aaronchongth

While running simulation tests, I noticed that

the simulation is already running, then only we start the api-server, it will segfault
after starting the api-server, then starting the simulation, the segfault occurs when a task is dispatched

koonpeng · 2024-06-26T07:53:26Z

By segfault, you mean that rmf crashes? Let me see if I can reproduce it.

koonpeng · 2024-06-26T08:23:45Z

Not able to reproduce it, though I get a different error

[fleet_adapter-14] Other error for tinyRobot2 in get_data: 'robot_name'

aaronchongth · 2024-06-27T02:27:08Z

Sorry that was cryptic of me, I mean't api-server crashes. Let me attach some screenshots

As for the different error, it looks like you may have an outdated workspace, I remember seeing this error before I rebuilt off main for everything

Co-authored-by: Aaron Chong <aaronchongth@gmail.com>

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

koonpeng · 2024-06-27T03:14:55Z

I'm not able to reproduce it, I can run with sim and managed to send a task. It could be due to some dependency conflict, python shouldn't normally segfault.

aaronchongth

Thanks for supporting this! LGTM

Looks like our migration effort of deployment branches have more to keep up with!

edit: not sure what was wrong with my setup, but after a full restart, rebuilding of my RMF workspace off main, and rmf-web of your branch, things are working well again.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

…ble" This reverts commit 1fd22ee.

…ble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* First iteration of generic alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Route for unresponded alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic location complete post route for task Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Tests for alert routes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Test for location complete route Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic implementation Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic task based alerts working as expected Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Only display and list alerts that have display true Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Add doc to location_complete route about instability Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored alert db interactions to repository, with lru cache for location alerts checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerated docs and return early on gateway last location checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and better typing with static methods Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/generic alerts without location (#951) * First round of cleanup Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerate API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/demo tasks (#925) * Moved custom deliveries to separate file naively and import naively Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved patrol Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved custom-compose Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added clean and delivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added delivery, renamed to SimpleDelivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean task added Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved delivery-custom tests, added return type for forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Configurable supported tasks and name remapping Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Changed directory to types, since it doesn't just handle descriptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix test imports Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using temporary task definition Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactoring new rename changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed problematic and unsused component and test Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updating pnpm version in github workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting update to pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix build now that we use key value strings for labels Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored last parts of hard coding categories and rendering forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactor callback names and error handling for misconfigs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Display error as well Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixed more checks and failures Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Split configuration and definition, only handle configurations in resource manager level Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Not using object as a type Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Render using validTasks instead Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use useMemo Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update ros2 pydantic messages, fix tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert update of pnpm lock file Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use specific exceptions and more clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Setup pnpm and node manually Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using HOME env var of runner Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback on frontend Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address comments that don't break behavior Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Started generic exceptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Proper db schema for alert request and response Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Attempt to setup minimal RMF during bootstrap step Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix mistake on ci path Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert CI changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated API, renamed event to pushAlert, filter before Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

koonpeng added 7 commits June 12, 2024 05:35

remove .venv

1753adc

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

cleanup

33c93e3

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

bootstrap pipenv in venv

8b0a947

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

jazzy

c29ece0

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

updating images

e74627d

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

trigger workflow

6392073

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update workflow

557a1a8

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

koonpeng force-pushed the koonpeng/jazzy branch 3 times, most recently from 1901214 to eee7fa3 Compare June 12, 2024 08:34

update scripts

191af6e

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

koonpeng force-pushed the koonpeng/jazzy branch from eee7fa3 to 191af6e Compare June 12, 2024 08:36

koonpeng added 10 commits June 12, 2024 08:41

set concurrency

fdedec7

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update docker workflow

3cd5a4e

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update docker workflow

8b7772e

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

trigger workflow

7afba7e

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

fix source

b703bf8

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

undo push nightly

96e1394

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update workflows

ffcaee9

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update workflows

513b19c

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update workflows

b138a39

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

update workflows

1a94533

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

koonpeng requested a review from aaronchongth June 12, 2024 10:09

koonpeng added 2 commits June 12, 2024 10:14

update workflows

d6775ce

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

force install pipenv even if it already exist on the system

0224578

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

aaronchongth approved these changes Jun 26, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

aaronchongth requested changes Jun 26, 2024

View reviewed changes

koonpeng and others added 2 commits June 27, 2024 11:02

Update README.md

5b7af0a

Co-authored-by: Aaron Chong <aaronchongth@gmail.com>

Merge remote-tracking branch 'origin/main' into koonpeng/jazzy

a7feba4

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

aaronchongth approved these changes Jul 1, 2024

View reviewed changes

aaronchongth merged commit 07f09ab into main Jul 1, 2024
7 checks passed

aaronchongth deleted the koonpeng/jazzy branch July 1, 2024 02:40

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble

1fd22ee

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Hum…

2e9cb5c

…ble" This reverts commit 1fd22ee.

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Hum…

01d68fe

…ble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support jazzy #955

support jazzy #955

koonpeng commented Jun 12, 2024 •

edited

Loading

aaronchongth left a comment

koonpeng commented Jun 26, 2024

koonpeng commented Jun 26, 2024

aaronchongth commented Jun 27, 2024

koonpeng commented Jun 27, 2024 •

edited

Loading

aaronchongth left a comment •

edited

Loading

support jazzy #955

support jazzy #955

Conversation

koonpeng commented Jun 12, 2024 • edited Loading

What's new

Self-checks

Discussion

aaronchongth left a comment

Choose a reason for hiding this comment

koonpeng commented Jun 26, 2024

koonpeng commented Jun 26, 2024

aaronchongth commented Jun 27, 2024

koonpeng commented Jun 27, 2024 • edited Loading

aaronchongth left a comment • edited Loading

Choose a reason for hiding this comment

koonpeng commented Jun 12, 2024 •

edited

Loading

koonpeng commented Jun 27, 2024 •

edited

Loading

aaronchongth left a comment •

edited

Loading