Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic build and upload for dashboad #994

Merged
merged 28 commits into from
Aug 16, 2024
Merged

Basic build and upload for dashboad #994

merged 28 commits into from
Aug 16, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Aug 8, 2024 •
edited

What's new

Docker images for general use

  • dashboard
  • api-server

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Basic build and upload for dashboad
cc1359f 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Default base image
5e105c5 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
install curl
4640977 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Passing build args
058a78c 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Install curl in second step image
682811b 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Not install serve globally
eba275f 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Adding npm bin to path
77caa8f 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fix entry point with bash too
44e7c68 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use CMD instead of ENTRYPOINT
f9f3c05 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Just use bash at the moment to debug
488c105 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use npx
ca85e47 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Basic api-server image
822df45 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Revert dashboard entry script, api-server to enter bash for debugging
6cc90c7 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Source minimal rmf instead of ros, before starting api-server
1b63a5e 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Make api-server image smaller
369517d 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use strings in dockerfile
141b9a6 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth force-pushed the feature/docker-images branch 4 times, most recently from 23cc295 to 51944b7 Compare August 14, 2024 09:10
@aaronchongth
Change default args for whole Dockerfile
c4a69c2 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Set builds as nightly, update README
1bd9fd5 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review August 14, 2024 10:03
@aaronchongth
Point to PMC board
0588b10 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Aug 15, 2024
Merged
koonpeng
koonpeng requested changes Aug 15, 2024
View reviewed changes
.github/dashboard/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@aaronchongth
Share docker images between build steps with dependencies, update README
31b6489 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use specific tags to ensure no pulling is involved
6e50306 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Revert to just use docker registry instead of manual loading
ec9b491 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Inject env script
7dafc12 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Merge branch 'main' into feature/docker-images
c7e525d 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use configurable configs, inject envs before start
5386df0 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use nginx instead
ede148b 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Revert nginx use, run injection script during entrypoint command
3d322bf 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Revert testing changes, update README
61b81d1 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit f39dfb8 into main Aug 16, 2024
1 check passed
@aaronchongth aaronchongth deleted the feature/docker-images branch August 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PMC Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronchongth @koonpeng