Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rmf_cmake_uncrustify #115

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

Yadunund
Copy link
Member

We currently have the rmf_cmake_uncrustify package that is used for style checking with colcon test. The original reason for having this package and not using ament_cmake_uncrustify was that the latter did not support custom uncrustify configuration files. But this feature was merged upstream quite a while ago and has been part of foxy and galactic releases. Hence, switching back to ament_cmake_uncrustify for ease of maintenance and distribution.

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #115 (4e1a9db) into main (6acb517) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   17.84%   18.07%   +0.22%     
==========================================
  Files         812      812              
  Lines       70036    68681    -1355     
  Branches    29375    28502     -873     
==========================================
- Hits        12498    12414      -84     
+ Misses      42513    41358    -1155     
+ Partials    15025    14909     -116     
Flag Coverage Δ
tests 18.07% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....1.0/Rx/v2/src/rxcpp/operators/rx-subscribe_on.hpp 39.02% <0.00%> (-7.32%) ⬇️
...2/rmf_fleet_adapter/src/rmf_fleet_adapter/Task.cpp 44.32% <0.00%> (-5.16%) ⬇️
...2/rmf_fleet_adapter/test/phases/test_GoToPlace.cpp 25.96% <0.00%> (-3.85%) ⬇️
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.hpp 30.15% <0.00%> (-3.18%) ⬇️
...er/src/rmf_fleet_adapter/phases/ResponsiveWait.cpp 28.39% <0.00%> (-2.47%) ⬇️
...mf_fleet_adapter/test/phases/test_DispenseItem.cpp 31.81% <0.00%> (-2.28%) ⬇️
...f_fleet_adapter/jobs/detail/impl_SearchForPath.hpp 19.81% <0.00%> (-1.89%) ⬇️
...RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-merge.hpp 40.00% <0.00%> (-1.82%) ⬇️
...ter/services/detail/impl_FindEmergencyPullover.hpp 52.54% <0.00%> (-1.70%) ⬇️
...f_fleet_adapter/services/detail/impl_Negotiate.hpp 29.66% <0.00%> (-1.70%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acb517...4e1a9db. Read the comment docs.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests work as expected, thanks! LGTM

@aaronchongth aaronchongth merged commit ef1858c into main Nov 12, 2021
@aaronchongth aaronchongth deleted the use_ament_cmake_uncrustify branch November 12, 2021 10:11
thedevmanek pushed a commit to thedevmanek/rmf that referenced this pull request Sep 5, 2022
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants