Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/mock docker #42

Merged
merged 4 commits into from
May 10, 2021
Merged

Fix/mock docker #42

merged 4 commits into from
May 10, 2021

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented May 10, 2021 •
edited
Loading

Signed-off-by: Aaron Chong aaronchongth@gmail.com

Bug fix

Fixed bug

Fix applied

  • Checked fleet_name map is not a None type before proceeding
  • Increased the robot_state and robot_mode_request subscription callback queue size to 10
  • Publishes docking ending mode request once only
  • Removes robot from watching only when robot is no longer in Docking mode

@aaronchongth
Fixing possible Nonetype fleet name map
43c3399 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Increased callback queue
6e6a511 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Publish mode request to end docking only if the robot is still dockin…
941dbe4 
…g, removed hardcoded 5 publishes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Increase queue size for robot_mode_request subscription
8304e55 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Yadunund
Yadunund approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these fixes!

@Yadunund Yadunund merged commit 5994d0f into main May 10, 2021
@Yadunund Yadunund deleted the fix/mock-docker branch May 10, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mock_docker crashes when fleet_name missing in config
2 participants
@aaronchongth @Yadunund