Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requried attribute in xml launch file #69

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Aug 3, 2021

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

Bug fix

Fixed bug

Airport launch file throws an error when trying to run the demo:

...
launch.invalid_launch_file_error.InvalidLaunchFileError: Caught exception when trying to load file of format [xml]: Unexpected attribute(s) found in `node`: {'required'}

Even though the required attribute is supported for nodes on python launch files, based on the error above and the documentation found here: https://design.ros2.org/articles/roslaunch_xml.html it seems that it is not available on for xml launch files.

I believe we are only getting this error now on galactic due to the changes introduced here: ros2/launch#468.

Fix applied

required attribute has been removed from launch file.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing this!

@marcoag marcoag merged commit 9352df0 into main Aug 3, 2021
@marcoag marcoag deleted the fix/remove_unparsed_attribute branch August 3, 2021 09:44
marcoag pushed a commit that referenced this pull request Aug 16, 2021
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
marcoag pushed a commit that referenced this pull request Aug 16, 2021
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants