remove requried attribute in xml launch file #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
Bug fix
Fixed bug
Airport launch file throws an error when trying to run the demo:
Even though the
required
attribute is supported for nodes on python launch files, based on the error above and the documentation found here: https://design.ros2.org/articles/roslaunch_xml.html it seems that it is not available on forxml
launch files.I believe we are only getting this error now on
galactic
due to the changes introduced here: ros2/launch#468.Fix applied
required
attribute has been removed from launch file.