Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BoundingBox msgs from vision_msgs with internal variants #44

Merged
merged 5 commits into from Aug 25, 2022

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Jul 29, 2022

Signed-off-by: Yadunund yadunund@gmail.com

The msg definitions for vision_msgs::BoundingBox3D and vision_msgs::BoundingBox2D have API breaking changes between galactic and humble versions. To continue supporting both ROS 2 versions in RMF, this PR updates the Obstacle msg definition to include an internal BoundingBox msg and not rely on vision_msgs. But the new messages have the same definition as the galactic version of vision_msgs.

See https://github.com/ros-perception/vision_msgs

Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund changed the title Replaced BoundingBox msgs from vision_msgs with internal variants Replace BoundingBox msgs from vision_msgs with internal variants Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #44 (13e1586) into main (49320b9) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 13e1586 differs from pull request most recent head 1a2ed22. Consider uploading reports for the commit 1a2ed22 to get more accurate results

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage    5.15%    5.11%   -0.04%     
==========================================
  Files        1426     1424       -2     
  Lines      108080   107978     -102     
  Branches    10230    10184      -46     
==========================================
- Hits         5567     5525      -42     
- Misses      98592    98593       +1     
+ Partials     3921     3860      -61     
Flag Coverage Δ
tests 5.11% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-merge.hpp 41.81% <0.00%> (-3.64%) ⬇️
...er/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp 20.64% <0.00%> (-0.15%) ⬇️
...os2/rmf_task_ros2/src/rmf_task_ros2/Dispatcher.cpp 0.87% <0.00%> (-0.05%) ⬇️
.../rmf_task_ros2/src/rmf_task_ros2/DispatchState.cpp 0.00% <0.00%> (ø)
...leet_adapter/src/rmf_fleet_adapter/TaskManager.hpp 18.18% <0.00%> (ø)
..._adapter/src/rmf_fleet_adapter/BroadcastClient.cpp
...mf_fleet_adapter/test/mock/MockWebSocketServer.hpp
...leet_adapter/src/rmf_fleet_adapter/TaskManager.cpp 12.68% <0.00%> (+0.27%) ⬆️
...pp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-subscription.hpp 60.36% <0.00%> (+1.21%) ⬆️
...f_fleet_adapter/agv/internal_FleetUpdateHandle.hpp 28.57% <0.00%> (+1.57%) ⬆️
... and 5 more

@Yadunund Yadunund requested a review from codebot August 17, 2022 12:53
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund merged commit 50afd24 into main Aug 25, 2022
@Yadunund Yadunund deleted the fix/obstacle_msg branch August 25, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants