Address feedback

Signed-off-by: Arjo Chakravarty <arjoc@google.com>
open-rmf · Mar 25, 2024 · 29ddac4 · 29ddac4
1 parent cdff369
commit 29ddac4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/rmf_websocket/src/rmf_websocket/client/ClientWebSocketEndpoint.cpp b/rmf_websocket/src/rmf_websocket/client/ClientWebSocketEndpoint.cpp
@@ -80,6 +80,9 @@ std::string ConnectionMetadata::debug_data() const
     case ConnectionStatus::FAILED:
       status_string = "Closed";
       break;
+    default:
+      status_string = "Unknown";
+      break;
   }
 
 
@@ -129,7 +132,8 @@ websocketpp::lib::error_code ClientWebSocketEndpoint::connect()
   if (ec)
   {
     std::stringstream err;
-    err << "> Connect initialization error: " << ec.message();
+    err << "> Connect initialization error: " << ec.message() << std::endl
+        << "> Host: " << _uri << std::endl;
     _logger(err.str());
     return ec;
   }
@@ -138,7 +142,10 @@ websocketpp::lib::error_code ClientWebSocketEndpoint::connect()
     {
       // TODO(arjo) Parametrize the timeout.
       using namespace std::chrono_literals;
-      _logger("Attempting reconnection in 1s.");
+      std::stringstream err;
+      err << "> Reconnecting in 1s" << std::endl
+          << "> Host: " << _uri << std::endl;
+      _logger(err.str());
       std::this_thread::sleep_for(1s);
       connect();
     };
@@ -228,7 +235,8 @@ ClientWebSocketEndpoint::~ClientWebSocketEndpoint()
   if (ec)
   {
     std::stringstream err;
-    err << "> Error closing connection : " << ec.message();
+    err << "> Error closing connection : " << ec.message() << std::endl
+        << "> Host: " << _uri << std::endl;
     _logger(err.str());
   }
 

diff --git a/rmf_websocket/src/rmf_websocket/client/ClientWebSocketEndpoint.hpp b/rmf_websocket/src/rmf_websocket/client/ClientWebSocketEndpoint.hpp
@@ -146,4 +146,4 @@ class ClientWebSocketEndpoint
   ConnectionCallback _connection_cb;
 };
 }
-#endif
+#endif