Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state as underway during perform action #206

Merged
merged 2 commits into from
May 12, 2022

Conversation

youliangtan
Copy link
Member

@youliangtan youliangtan commented May 6, 2022

During performaction event, the state was shown as "standby". It is more understandable to users if the state is shown as "underway" during an ongoing perform action task. Single line fix
.

Signed-off-by: youliang <tan_you_liang@hotmail.com>
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #206 (736b319) into main (1b8939d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   17.90%   17.88%   -0.02%     
==========================================
  Files         420      840     +420     
  Lines       38604    77212   +38608     
  Branches    18498    37000   +18502     
==========================================
+ Hits         6911    13813    +6902     
- Misses      24283    48573   +24290     
- Partials     7410    14826    +7416     
Flag Coverage Δ
tests 17.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../rmf_ros2/rmf_fleet_adapter/src/read_only/main.cpp
...ros2/src/rmf_traffic_ros2/schedule/Negotiation.cpp
...dapter/src/rmf_fleet_adapter/phases/IngestItem.cpp
...p/RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-map.hpp
...mf_rxcpp/include/rmf_rxcpp/detail/RxJobsDetail.hpp
...RxCpp-4.1.0/Rx/v2/src/rxcpp/sources/rx-iterate.hpp
...-4.1.0/Rx/v2/src/rxcpp/operators/rx-take_until.hpp
..._adapter/src/rmf_fleet_adapter/agv/parse_graph.cpp
...-4.1.0/Rx/v2/src/rxcpp/schedulers/rx-eventloop.hpp
...f_fleet_adapter/src/rmf_fleet_adapter/agv/Node.cpp
... and 1250 more

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yadunund
Copy link
Member

Btw @youliangtan you can also use the override API to set the status from the fleet adapter implementation
#191

@youliangtan
Copy link
Member Author

The override api is to update the robot status. The updated underway status is a task status.

@Yadunund
Copy link
Member

Thanks for clarifying. I got the two mixed up for a moment 😅

@Yadunund Yadunund merged commit 212225e into main May 12, 2022
@Yadunund Yadunund deleted the fix/perform-action-underway-status branch May 12, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants