Add support of fleet-level task #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
requested changes
Jan 11, 2024
rmf_fleet_adapter/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp
Outdated
Show resolved
Hide resolved
rmf_fleet_adapter/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp
Outdated
Show resolved
Hide resolved
cwrx777
force-pushed
the
charlywrx/support_fleet_task
branch
from
33dea92
to
236a29b
Compare
Yadunund
approved these changes
Jan 16, 2024
Yadunund
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Looks like there are some whitespaces on line 506 which is making CI unhappy. Can you format the code? ament_uncrustify -c ~/ws_rmf/src/rmf/rmf_utils/rmf_utils/test/format/rmf_code_style.cfg ~/ws_rmf/src/rmf/rmf_ros2/rmf_fleet_adapter/src/rmf_fleet_adapter/ --reformat should automatically format the code.
Yadunund
previously approved these changes
Jan 16, 2024
|
@cwrx777 can you ensure all your commits are signed? |
|
@cwrx777 merging is blocked by not having signed commits. |
cwrx777
force-pushed
the
charlywrx/support_fleet_task
branch
from
fc7a0bb
to
abe7165
Compare
…fleet adapter's name. Signed-off-by: Charly Wu <charlywu@medinno.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
cwrx777
force-pushed
the
charlywrx/support_fleet_task
branch
7 times, most recently
from
28321b6
to
e7bd7dc
Compare
|
@cwrx777 looks like something went wrong with the rebase and there are several new commits and diffs. Could you grant me push access to your fork/branch? I can clean this up and get it merged. |
Yadunund
force-pushed
the
charlywrx/support_fleet_task
branch
from
e7bd7dc
to
7ea8490
Compare
Yadunund
approved these changes
Jan 26, 2024
arjo129
pushed a commit
that referenced
this pull request
Jun 7, 2024
* check if task request has fleet_name and reject if it does not match fleet adapter's name. Signed-off-by: Charly Wu <charlywu@medinno.com> * update logging. Signed-off-by: Charly Wu <charlywu@medinno.com> * added DCO commit Signed-off-by: Charly Wu <charlywu@medinno.com> * delete unnecessary new lines. Signed-off-by: Charly Wu <charlywu@medinno.com> * remove extra space. Signed-off-by: Charly Wu <charlywu@medinno.com> * uncrustified. Signed-off-by: Charly Wu <charlywu@medinno.com> --------- Signed-off-by: Charly Wu <charlywu@medinno.com> Co-authored-by: Yadu <yadunund@openrobotics.org> Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleet-level task is implemented by ignoring
bid_noticemsg inbid_notice_cbif thefleet_namein the task_request does not match the fleet's name.