Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This fix is partly to address the potential issue when build with
--symlink-install
. open-rmf/rmf#24.Fix
Previously the
rmf_fleet_adapter_python
will invoke a cmake build fromsetup.py
. This PR will remove the need ofsetup.py
, and install the pkg viaament_python_install_package()
in the CMakeList.Also, the package
ament_python
is removed, and replaced with pybind11_vendor. This will be installed duringrosdep
.Test
# Compile, with and without `--symlink-install` ros2 run rmf_fleet_adapter_python test_adapter.py
-- in-progress --
colcon test