Fix deadlock in websocket server #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rather dumb mistake. I think I left this in as a vestige of my testing. However, the websocket client was refusing to reconnect thanks to a deadlock caused by this variable. Signed-off-by: Arjo Chakravarty <arjoc@google.com>
koonpeng
approved these changes
Apr 22, 2024
arjo129
added a commit
that referenced
this pull request
Jun 7, 2024
This is a rather dumb mistake. I think I left this in as a vestige of my testing. However, the websocket client was refusing to reconnect thanks to a deadlock caused by this variable. Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
OK So I'm not too happy with this "Fix" but it probably will resolve our deadlock issue.
This fixes a deadlock we were facing in production where in the event the server fails to connect after a reconnection is requested, the library deadlocks.