Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary qt5 dependency from CMakeLists #22

Merged
merged 1 commit into from Jun 1, 2021

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Jun 1, 2021

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #22 (ee314a1) into main (d4c237d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #22     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         24      46     +22     
  Lines       1888    3752   +1864     
=======================================
- Misses      1888    3752   +1864     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ing_sim_gazebo_plugins/src/thumbnail_generator.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
.../rmf_simulation/rmf_robot_sim_common/src/utils.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
...lation/rmf_robot_sim_common/src/slotcar_common.cpp
...tion/rmf_robot_sim_common/src/dispenser_common.cpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
... and 56 more

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@luca-della-vedova luca-della-vedova merged commit e711737 into main Jun 1, 2021
@luca-della-vedova luca-della-vedova deleted the fix/sim_plugins_dependencies branch June 1, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants