Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error on qt > 5.14 #27

Merged
merged 1 commit into from Jun 28, 2021
Merged

fix compile error on qt > 5.14 #27

merged 1 commit into from Jun 28, 2021

Conversation

koonpeng
Copy link

@koonpeng koonpeng commented Jun 28, 2021

Bug fix

qt > 5.14 had a bug which causes parsing error on intel tbb used by gazebo. A workaround is to wrap certain includes in #ifndef Q_MOC_RUN.

Related qt bugs
https://bugreports.qt.io/browse/QTBUG-80990
https://bugreports.qt.io/browse/QTBUG-80578
https://bugreports.qt.io/browse/QTBUG-88125

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #27 (d58b7cd) into main (3bb8cd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main     #27      +/-   ##
========================================
  Coverage   0.00%   0.00%              
========================================
  Files        420      46     -374     
  Lines      35440    3752   -31688     
========================================
+ Misses     35440    3752   -31688     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._robot_sim_gazebo_plugins/src/TeleportIngestor.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
...lation/rmf_building_sim_common/src/lift_common.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
... and 452 more

@koonpeng koonpeng merged commit 706c147 into main Jun 28, 2021
@koonpeng koonpeng deleted the fix/qt-5.14 branch June 28, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants