Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for Ignition robot sim package #45

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

luca-della-vedova
Copy link
Member

Bug fix

Fixed bug

The rmf_robot_sim_ignition_plugins package had the leftover hack to make Ignition Edifice a non-mandatory dependency and silently skip compilation if it was not installed. Basically does the same as #31

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #45 (eea3a7c) into main (0f44ea4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main     #45      +/-   ##
========================================
  Coverage   0.00%   0.00%              
========================================
  Files        270     138     -132     
  Lines      25615   12873   -12742     
========================================
+ Misses     25615   12873   -12742     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
...ation/rmf_building_sim_gazebo_plugins/src/lift.cpp
...robot_sim_gazebo_plugins/src/TeleportDispenser.cpp
...m_ignition_plugins/src/LightTuning/LightTuning.cpp
...ion/rmf_robot_sim_ignition_plugins/src/slotcar.cpp
...obot_sim_ignition_plugins/src/TeleportIngestor.cpp
...ion/rmf_robot_sim_ignition_plugins/src/slotcar.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
..._robot_sim_gazebo_plugins/src/TeleportIngestor.cpp
... and 386 more

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
marcoag
marcoag previously approved these changes Sep 6, 2021
@luca-della-vedova luca-della-vedova merged commit d683575 into main Sep 7, 2021
@luca-della-vedova luca-della-vedova deleted the fix/release_dependencies branch September 7, 2021 03:19
luca-della-vedova added a commit that referenced this pull request Mar 8, 2022
* Fix dependencies for Ignition robot sim package

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Update changelog

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants