Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default lift current mode to AGV #52

Merged
merged 1 commit into from Sep 17, 2021

Conversation

cnboonhan
Copy link
Contributor

@cnboonhan cnboonhan commented Sep 15, 2021

Signed-off-by: Charayaphan Nakorn Boon Han charayaphan.nakorn.boon.han@gmail.com

Bug fix

Fixed bug

https://github.com/open-rmf/rmf_simulation/blob/main/rmf_building_sim_common/src/lift_common.cpp#L271
https://github.com/open-rmf/rmf_simulation/blob/main/rmf_building_sim_common/src/lift_common.cpp#L254-L258
Currently, the plugin defaults to publishing MODE_UNKNOWN as the initial current_mode. This causes issues downstream in rmf-web open-rmf/rmf-web#510

Fix applied

Enforce initial state of lift to be AGV mode for gazebo simulations

@cnboonhan cnboonhan added this to In Review in Research & Development via automation Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #52 (5639190) into main (b70c6a0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #52     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files        204     138     -66     
  Lines      19196   12845   -6351     
=======================================
+ Misses     19196   12845   -6351     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._building_sim_gazebo_plugins/src/toggle_floors.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
.../rmf_simulation/rmf_robot_sim_common/src/utils.cpp
...ion/rmf_robot_sim_ignition_plugins/src/slotcar.cpp
...ion/rmf_robot_sim_ignition_plugins/src/slotcar.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
..._building_sim_gazebo_plugins/src/toggle_floors.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
...building_sim_common/src/crowd_simulator_common.cpp
... and 320 more

Signed-off-by: Charayaphan Nakorn Boon Han <charayaphan.nakorn.boon.han@gmail.com>
@cnboonhan
Copy link
Contributor Author

lift_with_rmf_web-2021-09-15_20.07.49.mp4

@cnboonhan cnboonhan merged commit 5746ac7 into main Sep 17, 2021
@cnboonhan cnboonhan deleted the fix/lift_default_current_mode branch September 17, 2021 07:57
Research & Development automation moved this from In Review to Done Sep 17, 2021
luca-della-vedova pushed a commit that referenced this pull request Mar 8, 2022
Signed-off-by: Charayaphan Nakorn Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants