Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChargeBattery finish_time earlier than start_time #30

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Fix ChargeBattery finish_time earlier than start_time #30

merged 1 commit into from
Jul 29, 2021

Conversation

Yadunund
Copy link
Member

Fix #29

@Yadunund
Return if battery soc of robot is greater than recharge_soc
9552e15 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund added this to In Review in Research & Development via automation Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #30 (9552e15) into main (a407858) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   38.85%   38.80%   -0.06%     
==========================================
  Files          27       27              
  Lines        1498     1500       +2     
  Branches      903      904       +1     
==========================================
  Hits          582      582              
- Misses        221      222       +1     
- Partials      695      696       +1
Flag Coverage Δ
tests 38.80% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rmf_task/src/rmf_task/requests/ChargeBattery.cpp 43.24% <0.00%> (-1.21%) ⬇️

youliangtan
youliangtan approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yadunund Yadunund merged commit 87a7cad into main Jul 29, 2021
Research & Development automation moved this from In Review to Done Jul 29, 2021
@Yadunund Yadunund deleted the fix/ChargeBattery branch July 29, 2021 05:52
@Yadunund Yadunund mentioned this pull request Jul 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youliangtan youliangtan youliangtan approved these changes

Assignees

@youliangtan youliangtan

Labels
None yet
Projects
Research & Development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChargeBattery task with finish_time earlier than start_time
2 participants
@Yadunund @youliangtan