Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: align vertices colinear #372

Merged
merged 6 commits into from Jul 28, 2021
Merged

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Jul 28, 2021

Implemented feature

This PR adds multiple vertex selection by holding down SHIFT and clicking vertices to add them to the current selection. All selected vertices will all be rendered as red. You can clear the current selection by pressing the Escape key, as before.

When multiple vertices are selected that are directly connected by edges, you can press the slash key / or use the new menu item Edit->Align Colinear, and it will attempt to compute an orthogonal projection of all intermediate vertices onto the line between the first and last vertices in the selected chain.

Implementation description

There are probably corner cases that are not handled correctly, but at least it seems to work in the few situations that I've tried so far.

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot codebot requested a review from Yadunund July 28, 2021 02:49
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot
Copy link
Contributor Author

codebot commented Jul 28, 2021

implements #371

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this so quickly! Works great after the latest changes 💯

@Yadunund Yadunund merged commit c9e9229 into main Jul 28, 2021
@Yadunund Yadunund deleted the feature/vertex_colinear_tool branch July 28, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants