Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve build error on some systems with size_t namespace #374

Merged
merged 2 commits into from Aug 4, 2021

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Aug 4, 2021

On some systems and some compilers, apparently the cascade of includes in some files in traffic-editor does not include size_t outside the std namespace, for some files. This PR just adds std:: in front of all uses of size_t so that the code is more portable.

Signed-off-by: Morgan Quigley morgan@osrfoundation.org

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot codebot requested a review from Yadunund August 4, 2021 03:35
Yadunund
Yadunund previously approved these changes Aug 4, 2021
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot
Copy link
Contributor Author

codebot commented Aug 4, 2021

Using the std:: namespace for size_t is intended to resolve the issue described in open-rmf/rmf#85

@codebot codebot self-assigned this Aug 4, 2021
@codebot codebot requested a review from Yadunund August 4, 2021 07:08
@codebot codebot merged commit 210b41b into main Aug 4, 2021
@codebot codebot deleted the bug/add_std_to_size_t branch August 4, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants