Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to Humble #48

Merged
merged 12 commits into from
Sep 2, 2022
Merged

Conversation

luca-della-vedova
Copy link
Member

Bug fix

Fixed bug

Update CI to newest setup-ros action / Humble and Ubuntu Jammy, as done in open-rmf/rmf_simulation#77

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova marked this pull request as ready for review September 1, 2022 06:20
@Yadunund
Copy link
Member

Yadunund commented Sep 1, 2022

Could you also copy over the style CI? And update the readme to display both badges

@Yadunund
Copy link
Member

Yadunund commented Sep 1, 2022

And wondering if this should target the feature/rmf_obstacle branch?

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova changed the base branch from main to feature/rmf_obstacle September 1, 2022 06:27
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova
Copy link
Member Author

All done! Retargeting the rmf_obstacle branch, had to add a few code style changes (result of ament_uncrustify --reformat) to make CI green.
I had a bit of trouble with ${rmf_utils_DIR} not being populated for a few packages so I added an explicit find_package(rmf_utils REQUIRED) for test builds, as well as a test_dependency in package.xml to fix them.

CI is now green, merging this in the rmf_obstacle branch should also make its CI green and unblock the PR

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this issue. Looks good! Just have one very tiny nitpick on what uncrustify did

rmf_visualization_navgraphs/src/NavGraphVisualizer.cpp Outdated Show resolved Hide resolved
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova merged commit 3bff340 into feature/rmf_obstacle Sep 2, 2022
@luca-della-vedova luca-della-vedova deleted the fix/update_ci branch September 2, 2022 04:07
Yadunund added a commit that referenced this pull request Sep 7, 2022
* Added publisher for human markers

Signed-off-by: Yadunund <yadunund@gmail.com>

* Set level and frame name through params

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Bbox from Obstacle

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Remove ObstacleData

Signed-off-by: Yadunund <yadunund@gmail.com>

* Skeleton for navgraph visualization

Signed-off-by: Yadunund <yadunund@gmail.com>

* Create sub

Signed-off-by: Yadunund <yadunund@gmail.com>

* Remove data struct

Signed-off-by: Yadunund <yadunund@gmail.com>

* Make obstacle visualizer a component

Signed-off-by: Yadunund <yadunund@gmail.com>

* WIP

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Use rmf_traffic_ros2 convert api

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Navgraph publishing works with map change

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Publish waypoint markers

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Add more customizable parameters

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Update visuals for closed and speed limited lanes

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Fix transparency when opening lane

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Be more efficient of publishing lane marker updates

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Remove navgraph publishing from rmf_visualization_schedule

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Uncrustify

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Added skeleton for rmf_visualization_floorplan

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Add to launch file

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Cleanup rmf_visualization_schedule

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Converted schedule visualizer to component

Signed-off-by: Yadunund <yadunund@gmail.com>

* Finished porting schedule visualizer to component

Signed-off-by: Yadunund <yadunund@gmail.com>

* Use correct QoS

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Convert to cpp package

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Finish implementation

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Remove previous implementation

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Make nose scale a param

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Fix nose scale param

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Add obstacle visualizer to launch

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Grey out closed lanes

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Update text size

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Updated CI

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Fix nav_msgs dep and cleanup comments

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Update CI

Signed-off-by: Yadunund <yadunund@gmail.com>

* Use unique ns for obstacles

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Update CI to Humble (#48)

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>

* Update README

Signed-off-by: Yadunund <yadunund@gmail.com>

* Bump version and update changelogs

Signed-off-by: Yadunund <yadunund@gmail.com>

* Remove extra newline

Signed-off-by: Yadunund <yadunund@gmail.com>

Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Co-authored-by: Luca Della Vedova <luca@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants