Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/provider interface #186

Merged
merged 8 commits into from
Jul 27, 2020
Merged

Feat/provider interface #186

merged 8 commits into from
Jul 27, 2020

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented Jul 14, 2020

BREAKING

this will bump to 2.0.0 since it breaks the .request interface

changes from:

const result = await client.request("addition", [2, 2]});

to:

const result = await client.request({method: "addition", params: [2, 2]});

Also fixes up the typedoc:

image

@shanejonas shanejonas requested a review from zcstarr July 14, 2020 17:13
@shanejonas shanejonas force-pushed the feat/provider-interface branch 3 times, most recently from 9d7e0b5 to fbffbb3 Compare July 14, 2020 17:27
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          10       11    +1     
  Lines         365      369    +4     
  Branches       53       49    -4     
=======================================
+ Hits          363      367    +4     
  Misses          2        2           
Impacted Files Coverage Δ
src/Client.ts 100.00% <100.00%> (ø)
src/RequestManager.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37af797...5a3c194. Read the comment docs.

src/Error.ts Outdated Show resolved Hide resolved
src/ProviderInterface.ts Outdated Show resolved Hide resolved
src/ProviderInterface.ts Outdated Show resolved Hide resolved
src/RequestManager.ts Outdated Show resolved Hide resolved
src/RequestManager.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@shanejonas
Copy link
Member Author

need to fix the .notify method interface as well

Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

src/Error.ts Outdated Show resolved Hide resolved
src/RequestManager.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@shanejonas shanejonas merged commit a6a4103 into master Jul 27, 2020
@shanejonas shanejonas deleted the feat/provider-interface branch July 27, 2020 17:01
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shanejonas shanejonas mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants