Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool should return non-zero exit code if any tests were failed #64

Closed
mersinvald opened this issue Jul 31, 2019 · 1 comment · Fixed by #65
Closed

Tool should return non-zero exit code if any tests were failed #64

mersinvald opened this issue Jul 31, 2019 · 1 comment · Fixed by #65
Assignees
@shanejonas
Labels
released

Comments

@mersinvald
Copy link

mersinvald commented Jul 31, 2019 •
edited
Loading

Currently open-rpc-test-coverage returns zero even if tests were failed, which makes it hard to use it in automated environments

How to reproduce

Grab any example of schema and server with some failing test

open-rpc-test-coverage -s ./openrpc.json --transport=http --reporter=console
if [[ $? -eq 0 ]]; then echo "Should be non-zero"; fi
@mersinvald mersinvald changed the title Tool chould return non-zero exit code if tests were failed Tool chould return non-zero exit code if any tests were failed Jul 31, 2019
@mersinvald mersinvald changed the title Tool chould return non-zero exit code if any tests were failed Tool should return non-zero exit code if any tests were failed Jul 31, 2019
shanejonas added a commit that referenced this issue Jul 31, 2019
@shanejonas
fix: exit with error code if errors exist
9b78b74 
fixes #64
@shanejonas shanejonas mentioned this issue Jul 31, 2019
Merged
shanejonas added a commit that referenced this issue Jul 31, 2019
@shanejonas
fix: exit with error code if errors exist
289de2e 
fixes #64
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanejonas shanejonas

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exit with error code if errors exist open-rpc/test-coverage
3 participants
@shanejonas @mersinvald @openrpc-bastion