fix: Post a highlight #101

a0m0rajab · 2023-05-22T18:50:44Z

What type of PR is this? (check all applicable)

Description

This adds "post on highlights" button to the extension for users.
fixes #88

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

src/pages/posthighlight.tsx

bdougie

This user experience is not great. We should change this to the following.

The social card is not needed since the user is already on GitHub.
We should populate the title (using the existing titles from the PR) and description (using the pr description generation endpoint)

On submit should use the AI.

a0m0rajab · 2023-05-22T20:08:37Z

Sure, I will remove the social cards, as for the generation, I will be waiting an answer from anush or divyansh to implement it.

Anush008 · 2023-05-23T09:35:35Z

Sure, I will remove the social cards, as for the generation, I will be waiting an answer from anush or divyansh to implement it.

We can conditionally render the "Post On Highlights" button in the extension drop-down page when the user visits a GitHub PR page authored by them and can have the title, PR URL pre-filled in the highlight creation form with a button to generate the description. I can add these once the we are good to go with your highlight creation form.

a0m0rajab · 2023-05-23T11:58:51Z

Thank you anush, I was stuck at the URL thingy, but unblocked right now.

bdougie · 2023-05-23T12:18:52Z

GitHub PR page authored by them

@Anush008 A user should be able to post highlights not authored by them. i.e. a feature they opened an issue on will be an option. Also, a maintainer or co-author is another scenario.

Anush008 · 2023-05-23T12:25:53Z

GitHub PR page authored by them

@Anush008 A user should be able to post highlights not authored by them. i.e. a feature they opened an issue on will be an option. Also, a maintainer or co-author is another scenario.

We have a check right now that prevents the "Add to highlights" button from being added to PRs not authored by the signed-in user. We'll have to remove that too.

Anush008 · 2023-05-24T03:40:15Z

Hey @a0m0rajab. About 33eb47d, the message passing between content-scripts and the extension is prone to closed-receiving-end errors. Be sure to check for those on the chrome://extensions page.

a0m0rajab · 2023-05-24T06:47:44Z

Thank you for that, I did not finish it yet, just committed to record my process and not lose it.

a0m0rajab · 2023-05-24T19:49:44Z

Daily update: added the endpoint and pushed the highlight to the website, next steps:

disable the post button while sending the network request
show a toast/page for a successful post of highlight and add a link to it like the LinkedIn logic:
I will need to refactor the code as well before the last push.
an issue I faced while doing this is that I did not get the id of the highlight from the backend.

a0m0rajab · 2023-05-24T21:53:43Z

Used statues code for error showing since there is no statue text right now.

a0m0rajab · 2023-05-24T22:13:51Z

Here is a video of the extension:

2023-05-25_00-56-44.mp4

Is there feedback about it right now? In the next iteration, I will add the needed checks for the post to insights button to conditionally disable it. Why not render it? Cause I think if the user sees the button will get curios about how to use it, which will be explained in the button text/

a0m0rajab · 2023-05-24T22:16:12Z

As for the

pr description generation endpoint

I think it's not enabled right now, will have to check that later.

a0m0rajab · 2023-05-25T13:42:07Z

@Anush008 I got stuck with the AI endpoint logic.
Could we pairprogram it together? I did not know how to debug it.

I tried to follow a logic similar to the one you used, but it did not give me any output.

Anush008 · 2023-05-25T14:19:23Z

@Anush008 I got stuck with the AI endpoint logic. Could we pairprogram it together? I did not know how to debug it.

I tried to follow a logic similar to the one you used, but it did not give me any output.

Definitely. Hit me up on Discord when you're ready. @anush#5038..

diivi · 2023-05-25T14:37:40Z

Is there feedback about it right now?

Looks good, but I think it feels a little bland rn, maybe use opensauced orange for the submit button.

bdougie · 2023-05-25T18:52:38Z

This will need a rebase from beta for a lint and merge conflict fix.

a0m0rajab · 2023-05-27T18:51:56Z

Side note: an option to have multiple shot prompts or even change the prompt to make it more feasible for social media would be great.

bdougie · 2023-05-27T18:55:48Z

From my perspective I feel to merge this PR and work on issues on a new one, since there is a breaking PR coming in the next few days. What do you think?

Making this a minimally viable product is the goal.

Adding a generate button would be more ideal than automating it. Running it automatically cost money and might not be the experience a user expects.
I did not see animation or a title propagated when I ran this locally.

diivi · 2023-05-27T18:57:54Z

are these fixable?

a0m0rajab · 2023-05-27T19:42:06Z

@bdougie are you on the latest commit? It's working locally for me. One thing that might need to be done is to refresh the page (CTRL+SHIFT+R) hard since the connection between content-scripts and popups might not work. If the issue is still after hard refresh can you share the output from the console in the extension and the GitHub page?

@diivi nope, this is a warning it keeps generating a warning when you solve it. There is a conflict in the lint options there.

2023-05-27_22-38-07.mp4

bdougie

The copy needs updates to give the user more context

src/pages/posthighlight.tsx

bdougie · 2023-05-29T13:15:47Z

@a0m0rajab I updated all the copy to be more descriptive for the user. @diivi or @Anush008 can you give this a code review?

We can iterate on this after this is merged, but for basic functionaly, it works.

src/pages/posthighlight.tsx

Anush008 · 2023-05-29T13:29:23Z

This PR uses message passing between the GH content-script and the pop-up page to get info from the GH webpage. Which as we previously experienced is prone to closed-receiving-end errors.
I do have an approach in mind to make this feature work without message passing. I can try it once we merge this. Other than that, this looks great. @a0m0rajab 👍👍.

Anush008

🚀

src/pages/posthighlight.tsx

bdougie · 2023-05-29T14:04:52Z

Let's merge this now as is and continue to iterate and improve this.

This will definitely need usage docs in docs.opensauced.pizza

a0m0rajab · 2023-05-29T14:06:49Z

@bdougie thank you for that.
@Anush008 As for the prone, did you face this issue on this PR? and what approach you got on mind?
I got such an error but solved it by following the documentation mentioning the async functions:

In the above example, sendResponse() was called synchronously. If you want to asynchronously use sendResponse(), add return true; to the onMessage event handler.

which I used at this line:
https://github.com/open-sauced/ai/pull/101/files#diff-12e3b206dc980349f2c064d6bb1e0068655e929b8a4bf1ad88bf4fb06c15d0a0R79

## [1.3.1-beta.4](v1.3.1-beta.3...v1.3.1-beta.4) (2023-05-29) ### 🐛 Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051))

github-actions · 2023-05-29T14:07:33Z

🎉 This PR is included in version 1.3.1-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Anush008 · 2023-05-29T14:16:07Z

Sometimes the message listener in the content-script unmounts and the sender(pop-up page) gets the closed-receiving-end errors. You can see the error log on the chrome://extensions page. Which is not a problem with the code but just a runtime issue.

Anush008 · 2023-05-29T14:26:19Z

Our previous encounter with closed-receiving-end errors was resolved here. #64 (comment). 51a5a4e.

## [1.4.0](v1.3.0...v1.4.0) (2023-06-03) ### ✅ Tests * add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac)) * add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6)) ### 🐛 Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051)) * remove auto-take message from triage.yml ([258a828](258a828)) * rename triage.yml ([3b9a14b](3b9a14b)) * undefined config during build ([#158](#158)) ([c986086](c986086)) ### 🍕 Features * latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7)) * uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))

github-actions · 2023-06-03T05:17:16Z

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.3.1-beta.4](open-sauced/ai@v1.3.1-beta.3...v1.3.1-beta.4) (2023-05-29) ### 🐛 Bug Fixes * Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051))

## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03) ### ✅ Tests * add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac)) * add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6)) ### 🐛 Bug Fixes * Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051)) * remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828)) * rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b)) * undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086)) ### 🍕 Features * latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7)) * uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))

a0m0rajab commented May 22, 2023

View reviewed changes

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

a0m0rajab changed the title ~~Fix: Post a highlight~~ fix: Post a highlight May 22, 2023

bdougie requested changes May 22, 2023

View reviewed changes

This was referenced May 23, 2023

fix: multiple-button-injections #107

Closed

fix: duplicate-button-injections using guards #110

Merged

a0m0rajab marked this pull request as draft May 24, 2023 06:48

a0m0rajab mentioned this pull request May 24, 2023

Feature: Inconsistency between documentation and result open-sauced/api#174

Closed

2 tasks

a0m0rajab marked this pull request as ready for review May 24, 2023 22:16

This was referenced May 24, 2023

Feature: adding statues text to the response open-sauced/api#175

Open

Feature: .env file for the api #126

Closed

a0m0rajab mentioned this pull request May 25, 2023

Bug: Getting PR commit messages is unstable #131

Closed

2 tasks

a0m0rajab added 4 commits May 26, 2023 01:03

feat: post on highlights

196c311

feat: add open graph GitHub

edcf4c0

feat: communicate between popup and content script

93d37b3

chore: remove social cards

c80092f

a0m0rajab requested a review from diivi May 27, 2023 17:51

a0m0rajab mentioned this pull request May 27, 2023

Feature: Incorporate Linkedin features #58

Closed

2 tasks

chore: add generate AI button to post highlight

cd7e990

bdougie approved these changes May 27, 2023

View reviewed changes

bdougie reviewed May 29, 2023

View reviewed changes

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

Update copy to help the user

6bd72d1

bdougie reviewed May 29, 2023

View reviewed changes

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

Update src/pages/posthighlight.tsx

7845065

bdougie reviewed May 29, 2023

View reviewed changes

src/pages/posthighlight.tsx Outdated Show resolved Hide resolved

fix toast message

799bdd4

Anush008 approved these changes May 29, 2023

View reviewed changes

src/pages/posthighlight.tsx Show resolved Hide resolved

bdougie merged commit e3b7051 into open-sauced:beta May 29, 2023
6 checks passed

github-actions bot pushed a commit that referenced this pull request May 29, 2023

chore(patch): release 1.3.1-beta.4 on beta channel [skip ci]

86880f6

## [1.3.1-beta.4](v1.3.1-beta.3...v1.3.1-beta.4) (2023-05-29) ### 🐛 Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051))

github-actions bot added the released on @beta label May 29, 2023

github-actions bot added the released label Jun 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Post a highlight #101

fix: Post a highlight #101

a0m0rajab commented May 22, 2023

bdougie left a comment

a0m0rajab commented May 22, 2023

Anush008 commented May 23, 2023 •

edited

a0m0rajab commented May 23, 2023

bdougie commented May 23, 2023 •

edited by Anush008

Anush008 commented May 23, 2023

Anush008 commented May 24, 2023 •

edited

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023 •

edited

a0m0rajab commented May 25, 2023

Anush008 commented May 25, 2023

diivi commented May 25, 2023

bdougie commented May 25, 2023

a0m0rajab commented May 27, 2023

bdougie commented May 27, 2023 •

edited

diivi commented May 27, 2023

a0m0rajab commented May 27, 2023

bdougie left a comment

bdougie commented May 29, 2023

Anush008 commented May 29, 2023 •

edited

Anush008 left a comment

bdougie commented May 29, 2023 •

edited

a0m0rajab commented May 29, 2023

github-actions bot commented May 29, 2023

Anush008 commented May 29, 2023

Anush008 commented May 29, 2023 •

edited

github-actions bot commented Jun 3, 2023

fix: Post a highlight #101

fix: Post a highlight #101

Conversation

a0m0rajab commented May 22, 2023

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

bdougie left a comment

Choose a reason for hiding this comment

a0m0rajab commented May 22, 2023

Anush008 commented May 23, 2023 • edited

a0m0rajab commented May 23, 2023

bdougie commented May 23, 2023 • edited by Anush008

Anush008 commented May 23, 2023

Anush008 commented May 24, 2023 • edited

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023

a0m0rajab commented May 24, 2023 • edited

a0m0rajab commented May 25, 2023

Anush008 commented May 25, 2023

diivi commented May 25, 2023

bdougie commented May 25, 2023

a0m0rajab commented May 27, 2023

bdougie commented May 27, 2023 • edited

diivi commented May 27, 2023

a0m0rajab commented May 27, 2023

bdougie left a comment

Choose a reason for hiding this comment

bdougie commented May 29, 2023

Anush008 commented May 29, 2023 • edited

Anush008 left a comment

Choose a reason for hiding this comment

bdougie commented May 29, 2023 • edited

a0m0rajab commented May 29, 2023

github-actions bot commented May 29, 2023

Anush008 commented May 29, 2023

Anush008 commented May 29, 2023 • edited

github-actions bot commented Jun 3, 2023

Anush008 commented May 23, 2023 •

edited

bdougie commented May 23, 2023 •

edited by Anush008

Anush008 commented May 24, 2023 •

edited

a0m0rajab commented May 24, 2023 •

edited

bdougie commented May 27, 2023 •

edited

Anush008 commented May 29, 2023 •

edited

bdougie commented May 29, 2023 •

edited

Anush008 commented May 29, 2023 •

edited