fix: view on open sauced #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdougie
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Thanks for fixing this @a0m0rajab and for provided such detailed before and afters.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2023
## [1.14.2-beta.1](v1.14.1...v1.14.2-beta.1) (2023-11-05) ### 🐛 Bug Fixes * view on open sauced ([#278](#278)) ([eb56300](eb56300))
|
🎉 This PR is included in version 1.14.2-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
## [1.14.2](v1.14.1...v1.14.2) (2023-11-06) ### 🐛 Bug Fixes * view on open sauced ([#278](#278)) ([eb56300](eb56300))
|
🎉 This PR is included in version 1.14.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thank you for the feedback! @bdougie I really appreciate that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add an edge case for view on open sauced, which checks the user profile and at the same time it fixes the inconsistent space that we had.
Note: There is extra space between the profile image and the button that could be fixed with #89.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #146
Closes #259
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?