-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: dialog box is not responsive #2001
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself. For full info on how to contribute, please check out our contributors guide. |
This is related to discussion we had about adding a highlight previously @OgDev-01 @isabensusan. For small screens, for now at least, it's probably best to have the modal take the full width. |
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. |
Assigned to you @5hraddha |
Hi @bdougie,
But, when the URL is long and doesn't have hyphen early on in it, the URL doesn't break and wrap and overflows the card. Few examples of such URL are:
In order to fix this issue, we can add css to add line breaks whenever necessary, without trying to preserve whole words reference. This is how card looks without the fix: This is how card looks after the suggested fix and URL broken without preserving whole words: If the team is fine to break the URL like so, I'll raise a PR to fix the issue as suggested. Thanks! |
@open-sauced/engineering please advise |
I think it's fine to break the URL so it fits/wraps but another option could be to use ellipsis. Twitter/X does this, e.g. The other thing I'd suggest on smaller screens is remove the margins (not padding) on the dialog so that it can get as much real estate as possible. I'll let @isabensusan chime in though. |
I wouldn't scope this into this fix but we do have the option to swap to short urls in the future. Dub.co has an API we are not using and we have oss.fyi and pza.fyi options. |
Yeah, this could be an enhancement in a future PR that we can discuss. |
@5hraddha checking in to see if you had time to take a look. |
Yeah, @bdougie . I'm good with Nick's suggestion to keep the ellipses for longer urls and remove margins. I could start working on that and raise a PR. In the meanwhile, if there is any other suggestions, I could always add it. Thanks! |
Sounds good @5hraddha. Feel free to tag me on your PR when it's ready. |
Sure, @nickytonline 👍 Thank you! |
Hi @nickytonline,
|
🎉 This issue has been resolved in version 1.74.1-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.75.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The text was updated successfully, but these errors were encountered: