Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: accessibility enhancement for footer component #2037

Closed
1 of 2 tasks
RitaDee opened this issue Nov 1, 2023 · 4 comments · Fixed by #2038
Closed
1 of 2 tasks

bug: accessibility enhancement for footer component #2037

RitaDee opened this issue Nov 1, 2023 · 4 comments · Fixed by #2038
Assignees
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working released on @beta released

Comments

@RitaDee
Copy link
Contributor

RitaDee commented Nov 1, 2023

Describe the bug

The Footer component in the app currently lacks essential accessibility features, making it challenging for users with disabilities to navigate and comprehend the content. This issue is created to address these accessibility concerns.

The primary accessibility issues in the Footer component are as follows:

  • The brand logo lacks an accessible text alternative (alt).
  • Some links do not have descriptive text, making their purpose unclear to screen reader users.
  • Social media icons are missing accessible descriptions.
  • The colour contrast in the footer does not meet accessibility standards.

Proposed Solution

To make the Footer component more accessible, the following actions should be taken:

  • Add an alt attribute to the brand logo's Image component with a descriptive text alternative.
  • Provide descriptive text for links to make their purpose clear to screen reader users.
  • Include accessible descriptions for social media icons using aria-label attributes.
  • Improve colour contrast by adjusting text styling or background colour.

Expected Outcome

After implementing the proposed accessibility improvements, we expect the Footer component to be more inclusive and user-friendly.

Steps to reproduce

  1. Go to 'https://app.opensauced.pizza/user/notifications?filter=all'
  2. Scroll to the bottom.
  3. Check the social icons.

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@RitaDee RitaDee added 🐛 bug Something isn't working 👀 needs triage labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member

All yours @RitaDee!

@nickytonline nickytonline added the a11y Issues related to accessibility label Nov 2, 2023
Copy link

open-sauced bot commented Nov 8, 2023

🎉 This issue has been resolved in version 1.74.1-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

open-sauced bot commented Nov 9, 2023

🎉 This issue has been resolved in version 1.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants