Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Svelte thumbnail missing in pills #2195

Closed
2 tasks done
brittneypostma opened this issue Nov 21, 2023 · 4 comments · Fixed by #2196
Closed
2 tasks done

Bug: Svelte thumbnail missing in pills #2195

brittneypostma opened this issue Nov 21, 2023 · 4 comments · Fixed by #2196
Assignees
Labels

Comments

@brittneypostma
Copy link
Contributor

Describe the bug

When onboarding and selecting Svelte as an interests, the svg is missing on the pill/badge. We added the svg to the topic-thumbnails directory, but this needs to be added to the img/icons/interests directory in an interesting format. It appears to be using an svg sprite with an image data uri when I compared the react svgs. Here are the 2 file types. I would attempt this, but I'm not sure how to get the format needed for that interests svg. I assume you just need to take the Svelte svg that was added and run it through some tool, but I don't know which one.
interests
thumbnail

Steps to reproduce

  1. Onboard or add Svelte as an interest
  2. See svelte Svelte instead of the svg

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@brittneypostma brittneypostma added 🐛 bug Something isn't working 👀 needs triage labels Nov 21, 2023
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@sital002
Copy link
Contributor

.take

Copy link

open-sauced bot commented Nov 21, 2023

🎉 This issue has been resolved in version 1.77.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

open-sauced bot commented Nov 21, 2023

🎉 This issue has been resolved in version 1.77.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants