fix: Star-search md rendering renders spacing from LLM #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <john@opensauced.pizza>
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I also came across this plugin: https://github.com/remarkjs/remark-breaks which would add |
nickytonline
approved these changes
May 7, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
May 7, 2024
## [2.25.0-beta.3](v2.25.0-beta.2...v2.25.0-beta.3) (2024-05-07) ### 🐛 Bug Fixes * Star-search md rendering renders spacing from LLM ([#3326](#3326)) ([7bf27f1](7bf27f1))
nickytonline
added a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: John McBride <john@opensauced.pizza> Co-authored-by: Nick Taylor <nick@nickyt.co>
open-sauced bot
pushed a commit
that referenced
this pull request
May 7, 2024
## [2.25.0](v2.24.2...v2.25.0) (2024-05-07) ### 🐛 Bug Fixes * Change announcement card on highlight feed to starsearch ([#3313](#3313)) ([a38af76](a38af76)) * Star-search md rendering renders spacing from LLM ([#3326](#3326)) ([7bf27f1](7bf27f1)) * style and layout fixes for StarSearch ([#3304](#3304)) ([599d8f6](599d8f6)) ### 🍕 Features * Issues and PR charts for Repo pages ([#3323](#3323)) ([97a6239](97a6239)) * search and select for workspaces in sidebar ([#3307](#3307)) ([5d91aaf](5d91aaf)) * uniform styling for Repo page charts ([#3306](#3306)) ([9cd008e](9cd008e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds 2 things primarily to the star-search markdown rendering:
data:frames are counted as newlines from the model. This is done by making the\sspacing capture in the regex optional and not forcing a capture in theresultscapture-group via.+: instead, we allow for any captures (including zero) through.*.This also changes
Markdown-->ReactMarkdown. This seems to be the way the library recommends rendering "safe" markdown that can't have code injected into it: https://www.npmjs.com/package/react-markdown/v/8.0.6I also noticed what seems to be some improvements to the rendering of the markdown switching to
ReactMarkdown.Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Before:
After:
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?