Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only tag maintainers for the specific repo on repo pages #3395

Merged
merged 1 commit into from
May 15, 2024

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented May 15, 2024

Description

  • Fixes the contributors tab on repo pages where only the maintainers for that repository are given the maintainer badge

Related Tickets & Documents

Related to: https://github.com/open-sauced/api/issues/793

Mobile & Desktop Screenshots/Recordings

BEFORE:

image

AFTER:

image

Steps to QA

  1. Navigate to repo page contributors on beta - https://beta.app.opensauced.pizza/s/analogjs/analog/contributors
  2. Note multiple people marked as maintainers in the contributors list
  3. Navigate to deploy preview https://deploy-preview-3395--oss-insights.netlify.app/s/analogjs/analog/contributors
  4. Note brandonroberts is marked as a maintainer in the contributors list

Validate no slow down of page load occurs also

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit bf2273f
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6644da60f400b40008160b2f
😎 Deploy Preview https://deploy-preview-3395--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit bf2273f
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6644da608a855b0008b9af3d
😎 Deploy Preview https://deploy-preview-3395--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@brandonroberts brandonroberts requested a review from a team May 15, 2024 16:10
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brandonroberts brandonroberts merged commit 54c9a93 into beta May 15, 2024
30 of 31 checks passed
@brandonroberts brandonroberts deleted the repo-page-maintainers branch May 15, 2024 16:28
open-sauced bot pushed a commit that referenced this pull request May 15, 2024
## [2.29.0-beta.1](v2.28.0...v2.29.0-beta.1) (2024-05-15)

### 🍕 Features

* only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93))
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0](v2.28.0...v2.29.0) (2024-05-16)

### 🍕 Features

* capture all StarSearch prompts in PostHog ([#3405](#3405)) ([f7d8ac6](f7d8ac6))
* implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681))
* only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93))

### 🐛 Bug Fixes

* Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478))
* correct placeholder text in HighlightInput component ([#3348](#3348)) ([2ea0d24](2ea0d24))
* fixed TS error and logic for gathering prompt response ([#3410](#3410)) ([36d26c2](36d26c2))
* remove unused waitlist components ([#3404](#3404)) ([a99b113](a99b113))
* styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants