Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change closed issue state to purple on issues table #3406

Merged
merged 1 commit into from
May 16, 2024

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented May 16, 2024

Description

Previously, the merged issue color was red. To maintainer uniformity, this uses purple.

Related Tickets & Documents

closes #3396

Mobile & Desktop Screenshots/Recordings

Before

image

After

image

Steps to QA

Deploy Preview: https://deploy-preview-3406--oss-insights.netlify.app/workspaces/3e97a217-2216-4d65-b7f6-846d181b9e83/issues?page=1

Running locally:

  1. Go to a workspace
  2. Click Activity
  3. Click Issues

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 16, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 2dce87c
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66464e94d9b27c0008c2c376
😎 Deploy Preview https://deploy-preview-3406--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 2dce87c
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66464e947ffaa000081c3a9d
😎 Deploy Preview https://deploy-preview-3406--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BekahHW BekahHW requested a review from a team May 16, 2024 18:27
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonroberts brandonroberts merged commit 71b4478 into beta May 16, 2024
19 checks passed
@brandonroberts brandonroberts deleted the fix/closed-issue-icon branch May 16, 2024 19:02
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0-beta.4](v2.29.0-beta.3...v2.29.0-beta.4) (2024-05-16)

### 🐛 Bug Fixes

* Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478))
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0](v2.28.0...v2.29.0) (2024-05-16)

### 🍕 Features

* capture all StarSearch prompts in PostHog ([#3405](#3405)) ([f7d8ac6](f7d8ac6))
* implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681))
* only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93))

### 🐛 Bug Fixes

* Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478))
* correct placeholder text in HighlightInput component ([#3348](#3348)) ([2ea0d24](2ea0d24))
* fixed TS error and logic for gathering prompt response ([#3410](#3410)) ([36d26c2](36d26c2))
* remove unused waitlist components ([#3404](#3404)) ([a99b113](a99b113))
* styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change color of closed issue icon on the issue table.
3 participants