Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front end] Mobile consideration for all organisms #43

Closed
4 tasks done
bdougie opened this issue Jul 11, 2022 · 5 comments · Fixed by #81
Closed
4 tasks done

[Front end] Mobile consideration for all organisms #43

bdougie opened this issue Jul 11, 2022 · 5 comments · Fixed by #81

Comments

@bdougie
Copy link
Member

bdougie commented Jul 11, 2022

  • Header
  • Tool Nav
  • Tools Display
  • Top Nav

Moving forward, let's consider mobile in all components as well.

@eryc-cc
Copy link
Contributor

eryc-cc commented Jul 19, 2022

Should the tables be horizontally scrollable, or should we change how the items will appear? @bdougie @chadstewart

@chadstewart
Copy link
Contributor

Should the tables be horizontally scrollable, or should we change how the items will appear? @bdougie @chadstewart

We can play around with both ideas. In making the app mobile friendly, I changed how the words look. They solve the problem but the UX isn't great which is something I'm trying to figure out now.

We could just make them scrollable in storybook and play around with the UX there.

@eryc-cc
Copy link
Contributor

eryc-cc commented Jul 19, 2022

I kinda prefer to group data on mobile with a nice presentation, instead of using tables with horizontal scroll.

We'd have to create a sorting box, though, because people wouldn't be able to click on the titles to sort on mobile. But it looks cleaner, and most importantly: doesn't hide information.

Here's an example, where you can see the EUR amount going. below the name and job title on mobile 👇

image

@bdougie
Copy link
Member Author

bdougie commented Jul 19, 2022

I like this grouping idea, it provides a much better experience than horizontal scrolling. Horizontal scrolling won't get the CNCF as a customer. Reminder, they hate that. - their horinzontal scrolling

Screen Shot 2022-07-19 at 1 54 07 PM

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants