Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Languages in ContributorCard expand when the name is too long #453

Closed
eryc-cc opened this issue Sep 28, 2022 · 6 comments · Fixed by #501
Closed

bug: Languages in ContributorCard expand when the name is too long #453

eryc-cc opened this issue Sep 28, 2022 · 6 comments · Fixed by #501
Assignees
Labels

Comments

@eryc-cc
Copy link
Contributor

eryc-cc commented Sep 28, 2022

Summary

Two things:

  1. When language label is too big, it increases the size of the entire component. We can break the line.
  2. The language color bar should be relative to how much code that person has written.

1 - Name is too long

Hey @sungoldtech I noticed there's an issue where if the text is large, it'll make everything expand. Maybe we should make the extra characters break to a new line.

I can also reference this in a new issue, so we can get this PR moving...

bug-overlap.mov

Originally posted by @pixelsbyeryc in #441 (review)


2 - Language color bar percentage should be relative

They should also be sized relative to the amount of code, like GitHub does...

Here's an example of GitHub: the size of each color is different, related to how much code is in that language

Screen Shot 2022-09-28 at 4 16 54 PM

@eryc-cc eryc-cc added the 🐛 bug Something isn't working label Sep 28, 2022
@eryc-cc eryc-cc added this to the Self serve SaaS - Week 40 milestone Sep 28, 2022
@OgDev-01
Copy link
Contributor

@pixelsbyeryc I think I've done the work to make the language color bar relative to the percentageUsed on #441. but the data we are getting currently has similar percentageUsed on all languages 👌.

@OgDev-01
Copy link
Contributor

OgDev-01 commented Oct 2, 2022

hey @pixelsbyeryc, looking closely at what we have now, I was thinking truncating the language name and adding a tooltip would look better than breaking into a new line 🙌.

breaking to a new line currently looks off
image

with trucate
image

then tooltip
image

let me know your take on this 🙏🙏

@OgDev-01 OgDev-01 self-assigned this Oct 2, 2022
@eryc-cc
Copy link
Contributor Author

eryc-cc commented Oct 3, 2022

I was thinking truncating the language name and adding a tooltip would look better than breaking into a new line 🙌.

@sungoldtech that works!

Do we have a tooltip component? cc @bdougie @brandonroberts

I designed a tooltip that you can use (click here to see).

Screen Shot 2022-10-03 at 4 08 07 PM

@bdougie
Copy link
Member

bdougie commented Oct 5, 2022

We do not, but I do like this better than the browser tooltip. We add this as an atom component and go from there.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants