fix: too many language in contibutors card #441

OgDev-01 · 2022-09-27T06:39:54Z

What type of PR is this? (check all applicable)

Description

This PR fixes too much language in contributors card

Related Tickets & Documents

Fixes #402

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2022-09-27T06:40:01Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`c5a0c5f`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63348997ca974f0008ab1ffe
😎 Deploy Preview	https://deploy-preview-441--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions

PR Compliance Checks Passed!

netlify · 2022-09-27T06:41:17Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`c5a0c5f`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63348997c6daa000098fe90b
😎 Deploy Preview	https://deploy-preview-441--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

0-vortex

small changes here and there and a big one (swr)

components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx

components/molecules/ContributorTable/contributor-table.tsx

components/molecules/RepoRow/repo-row.tsx

lib/hooks/useTopicContributorCommits.ts

lib/utils/get-recent-commits.ts

OgDev-01 · 2022-09-27T12:19:27Z

@0-vortex Just a quick note, most of these changes were introduced #431 @brandonroberts and I branched out of his branch to enable me work with updated data on #431 (review) .

0-vortex · 2022-09-27T12:22:57Z

@0-vortex Just a quick note, most of these changes were introduced #431 @brandonroberts and I branched out of his branch to enable me work with updated data on #431 (review) .

Roger that, resolve anything that is not related to your PR then! 🍕

brandonroberts · 2022-09-27T14:08:02Z

@sungoldtech will you rebase/merge and so its only your changes?

…02-too-many-language-in-contibutors-card

components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx

0-vortex

LGTM, 👍 on Brandon's changes

…r-chart.tsx Co-authored-by: Brandon <robertsbt@gmail.com>

brandonroberts · 2022-09-28T17:31:53Z

@sungoldtech preview deployment failed probably due to lint checks

brandonroberts

Looks good!

components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx

eryc-cc

Hey @sungoldtech I noticed there's an issue where if the text is large, it'll make everything expand. Maybe we should make the extra characters break to a new line.

I can also reference this in a new issue, so we can get this PR moving...

bug-overlap.mov

brandonroberts · 2022-09-28T19:26:42Z

@pixelsbyeryc let's open a new issue for what you're seeing and go ahead and merge this one

eryc-cc

@brandonroberts sounds good. Approving.

## [1.7.0-beta.14](v1.7.0-beta.13...v1.7.0-beta.14) (2022-09-28) ### 🐛 Bug Fixes * limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)

github-actions · 2022-09-28T19:33:31Z

🎉 This PR is included in version 1.7.0-beta.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28) ### 🍕 Features * add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404) * Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438) * adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395) ### 🐛 Bug Fixes * adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7)) * inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399) * limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402) * remove link from highlight card component ([#435](#435)) ([25b6997](25b6997)) * remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)

github-actions · 2022-09-28T21:31:18Z

🎉 This PR is included in version 1.8.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.8.0](v1.7.0...v1.8.0) (2022-09-28) ### 🍕 Features * add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404) * Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438) * adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395) ### 🐛 Bug Fixes * adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7)) * inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399) * limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402) * remove link from highlight card component ([#435](#435)) ([25b6997](25b6997)) * remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)

github-actions · 2022-09-28T21:39:07Z

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.7.0-beta.14](open-sauced/app@v1.7.0-beta.13...v1.7.0-beta.14) (2022-09-28) ### 🐛 Bug Fixes * limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)

## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28) ### 🍕 Features * add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404) * Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438) * adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395) ### 🐛 Bug Fixes * adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7)) * inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399) * limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402) * remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997)) * remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)

## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28) ### 🍕 Features * add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404) * Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438) * adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395) ### 🐛 Bug Fixes * adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7)) * inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399) * limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402) * remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997)) * remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)

brandonroberts and others added 13 commits September 26, 2022 09:39

feat: add data from API to contributors page

81aa7d4

chore: fix lint errors

1a0857d

feat: some refactoring and added support for pagination

213f79c

chore: change field to recent_repo_list

870a49e

feat: wire up latest pull requests per contributor

b64566a

chore: formatting

69a5fbb

chore: fix story for contributor table

c31b4fd

chore: temp deploy fix

a84db51

feat: connect recent commits to contributor graph

f82e4c3

chore: fix linter errors

2a6042c

chore: revert netlify change

a9d4461

fix: reduce displayed language list to 5

df77a0b

fix: fix percentage issues on div

5ca5bbf

github-actions bot reviewed Sep 27, 2022

View reviewed changes

OgDev-01 requested review from chadstewart, eryc-cc, brandonroberts, 0-vortex and bdougie September 27, 2022 06:41

OgDev-01 added the needs review PRs that need review from core engineering team label Sep 27, 2022

0-vortex suggested changes Sep 27, 2022

View reviewed changes

brandonroberts mentioned this pull request Sep 27, 2022

refactor: use swr instead of custom fetching from the API #444

Closed

OgDev-01 added 2 commits September 28, 2022 13:13

Merge branch 'beta' of https://github.com/open-sauced/insights into 4…

41a6165

…02-too-many-language-in-contibutors-card

fix: type infertion

c9ee97b

OgDev-01 requested a review from 0-vortex September 28, 2022 12:19

brandonroberts requested changes Sep 28, 2022

View reviewed changes

components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx Outdated Show resolved Hide resolved

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Sep 28, 2022

0-vortex approved these changes Sep 28, 2022

View reviewed changes

Update components/molecules/CardHorizontalBarChart/card-horizontal-ba…

75cd890

…r-chart.tsx Co-authored-by: Brandon <robertsbt@gmail.com>

refactor: update slice method to have start and end params

c5a0c5f

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Sep 28, 2022

OgDev-01 requested a review from brandonroberts September 28, 2022 17:53

brandonroberts approved these changes Sep 28, 2022

View reviewed changes

components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx Show resolved Hide resolved

eryc-cc suggested changes Sep 28, 2022

View reviewed changes

eryc-cc mentioned this pull request Sep 28, 2022

bug: Languages in ContributorCard expand when the name is too long #453

Closed

eryc-cc approved these changes Sep 28, 2022

View reviewed changes

brandonroberts merged commit 4aba355 into beta Sep 28, 2022

brandonroberts deleted the 402-too-many-language-in-contibutors-card branch September 28, 2022 19:29

github-actions bot added the released on @beta label Sep 28, 2022

github-actions bot added the released label Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: too many language in contibutors card #441

fix: too many language in contibutors card #441

OgDev-01 commented Sep 27, 2022 •

edited

Loading

netlify bot commented Sep 27, 2022 •

edited

Loading

github-actions bot left a comment •

edited

Loading

netlify bot commented Sep 27, 2022 •

edited

Loading

0-vortex left a comment

OgDev-01 commented Sep 27, 2022

0-vortex commented Sep 27, 2022

brandonroberts commented Sep 27, 2022

0-vortex left a comment

brandonroberts commented Sep 28, 2022

brandonroberts left a comment

eryc-cc left a comment •

edited

Loading

brandonroberts commented Sep 28, 2022

eryc-cc left a comment

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

fix: too many language in contibutors card #441

fix: too many language in contibutors card #441

Conversation

OgDev-01 commented Sep 27, 2022 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Sep 27, 2022 • edited Loading

✅ Deploy Preview for design-insights ready!

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

netlify bot commented Sep 27, 2022 • edited Loading

✅ Deploy Preview for oss-insights ready!

0-vortex left a comment

Choose a reason for hiding this comment

OgDev-01 commented Sep 27, 2022

0-vortex commented Sep 27, 2022

brandonroberts commented Sep 27, 2022

0-vortex left a comment

Choose a reason for hiding this comment

brandonroberts commented Sep 28, 2022

brandonroberts left a comment

Choose a reason for hiding this comment

eryc-cc left a comment • edited Loading

Choose a reason for hiding this comment

brandonroberts commented Sep 28, 2022

eryc-cc left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

OgDev-01 commented Sep 27, 2022 •

edited

Loading

netlify bot commented Sep 27, 2022 •

edited

Loading

github-actions bot left a comment •

edited

Loading

netlify bot commented Sep 27, 2022 •

edited

Loading

eryc-cc left a comment •

edited

Loading