Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front-End] Implement React Icons #63

Closed
Tracked by #62
pixelsbyeryc opened this issue Jul 14, 2022 · 6 comments
Closed
Tracked by #62

[Front-End] Implement React Icons #63

pixelsbyeryc opened this issue Jul 14, 2022 · 6 comments

Comments

@pixelsbyeryc
Copy link
Contributor

pixelsbyeryc commented Jul 14, 2022

Summary

Use React Icons to import any library of icons we need.

in hot we are using https://react-icons.github.io/react-icons/ and letting the vite optimiser dedupe imports and shake the tree - we should be able to use the same technique, in effect feel free to import any icons! 🍕

@0-vortex - #63 (comment)

We're using icons from a few libraries:

  • Heroicons
  • Octicons

We need to either add them to our project or import them to our project. What would be best @bdougie @chadstewart?

These icons will be used in our <Icon> component from #62.

@0-vortex
Copy link
Contributor

in hot we are using https://react-icons.github.io/react-icons/ and letting the vite optimiser dedupe imports and shake the tree - we should be able to use the same technique, in effect feel free to import any icons! 🍕

@pixelsbyeryc
Copy link
Contributor Author

Nice thinking!! 🔥 🍕 Thanks, @0-vortex!

I'm updating the task name to "Implement React Icons"

@pixelsbyeryc pixelsbyeryc changed the title [feat] Create our Icon library [Front-End] Implement React Icons Jul 15, 2022
@chadstewart
Copy link
Contributor

It should be noted that this will be completed with the merging of #203

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@0-vortex
Copy link
Contributor

PR comment should be closes #ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants