fix: reports select issue #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
approved these changes
Jun 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
### [1.50.1-beta.3](v1.50.1-beta.2...v1.50.1-beta.3) (2023-06-06) ### 🐛 Bug Fixes * reports select issue ([#1239](#1239)) ([a48bc87](a48bc87))
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
## [1.51.0](v1.50.0...v1.51.0) (2023-06-06) ### 🍕 Features * add share tracking ([#1250](#1250)) ([5b7d331](5b7d331)) * implement dynamic redirect on auth ([#1240](#1240)) ([548cc4d](548cc4d)) ### 🐛 Bug Fixes * Footer Location on Smaller Screens ([#1242](#1242)) ([8b2356a](8b2356a)) * reports select issue ([#1239](#1239)) ([a48bc87](a48bc87)) * update contributors hook to use contributor API endpoint ([#1238](#1238)) ([eff01c0](eff01c0)) * update hook for Posthog ([cd4f32c](cd4f32c)) * update medium activity threshold for repositories ([#1251](#1251)) ([4730533](4730533)), closes [#1224](#1224)
|
🎉 This PR is included in version 1.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
### [1.50.1-beta.3](open-sauced/app@v1.50.1-beta.2...v1.50.1-beta.3) (2023-06-06) ### 🐛 Bug Fixes * reports select issue ([#1239](open-sauced/app#1239)) ([a48bc87](open-sauced/app@a48bc87))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.51.0](open-sauced/app@v1.50.0...v1.51.0) (2023-06-06) ### 🍕 Features * add share tracking ([#1250](open-sauced/app#1250)) ([5b7d331](open-sauced/app@5b7d331)) * implement dynamic redirect on auth ([#1240](open-sauced/app#1240)) ([548cc4d](open-sauced/app@548cc4d)) ### 🐛 Bug Fixes * Footer Location on Smaller Screens ([#1242](open-sauced/app#1242)) ([8b2356a](open-sauced/app@8b2356a)) * reports select issue ([#1239](open-sauced/app#1239)) ([a48bc87](open-sauced/app@a48bc87)) * update contributors hook to use contributor API endpoint ([#1238](open-sauced/app#1238)) ([eff01c0](open-sauced/app@eff01c0)) * update hook for Posthog ([cd4f32c](open-sauced/app@cd4f32c)) * update medium activity threshold for repositories ([#1251](open-sauced/app#1251)) ([4730533](open-sauced/app@4730533)), closes [#1224](open-sauced/app#1224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Refactor the SelectReportsFilter component to allow for dynamic rendering of filter options and display the selected filter name in the dropdown trigger. The filterList prop is now required and the onValueChange function is added to update the selectedValue state. The selected filter name is now displayed in the dropdown trigger instead of "Select a Filter".
Generated using OpenSauced.
Note:
I removed the empty state of the select filter because it is redundant for as all filters are bond to have options and not empty options
Related Tickets & Documents
Fixes #1233
Mobile & Desktop Screenshots/Recordings
Before
Screen.Recording.2023-06-02.at.08.13.38.mov
After
Screen.Recording.2023-06-02.at.08.09.03.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?