Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use repository recommendations from the API #1323

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Jun 30, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Connects user recommendations tab to selected user interests
  • Refactors User Repository Recommendations into a separate component
  • Fixes bug where tab switching was not reflected in the URL
  • Adds a URL for recommendations to the user profile
  • Also cleans up some linter checks for imports

Related Tickets & Documents

Closes #1296

Mobile & Desktop Screenshots/Recordings

BEFORE:

image

AFTER:

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jun 30, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit b0be3ad
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/649f2b372d4ae200087816e1
😎 Deploy Preview https://deploy-preview-1323--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 30, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit b0be3ad
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/649f2b37eb8f9a0008c9edae
😎 Deploy Preview https://deploy-preview-1323--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@bdougie
Copy link
Member

bdougie commented Jun 30, 2023

Are we filtering based on stars in the data still? Freecodecamp and React seem so out of reach for even an experienced developer.

@brandonroberts
Copy link
Contributor Author

No, we're not filtering on stars. Its the active repositories that have been most recently updated that are returned. This is development data so its a bit stale

@bdougie
Copy link
Member

bdougie commented Jun 30, 2023

Oh that makes. The dev data always throws me off. I also tried testing the api in swagger but couldn't get a dev token to test on beta.

Regardless, let's move forward with this. It is much better than our current solution.

We will continue to tweak it after it's live.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward with it!

@brandonroberts brandonroberts merged commit aa8c33d into beta Jun 30, 2023
17 checks passed
@brandonroberts brandonroberts deleted the feat-repo-recommendations branch June 30, 2023 19:45
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
## [1.55.0-beta.3](v1.55.0-beta.2...v1.55.0-beta.3) (2023-06-30)

### πŸ• Features

* use repository recommendations from the API ([#1323](#1323)) ([aa8c33d](aa8c33d))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.55.0-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jul 6, 2023
## [1.55.0](v1.54.0...v1.55.0) (2023-07-06)

### πŸ› Bug Fixes

* adjust contributor distribution chart yscale max height ([#1329](#1329)) ([0c6b176](0c6b176))
* hide unnecessary scrollbar in profilepage ([#1327](#1327)) ([770f999](770f999))
* update author and license ([9a2c7de](9a2c7de))
* update DevCard component first contribution date format ([#1322](#1322)) ([951945c](951945c))
* update DevCard Contribution term to Repo ([#1321](#1321)) ([bc0d0cf](bc0d0cf))

### πŸ• Features

* add  `UserCard` to feeds page ([#1326](#1326)) ([b225eb3](b225eb3))
* add `NewsletterForm` component to design system ([#1311](#1311)) ([52573fb](52573fb))
* Hookup devcard page to real data ([#1302](#1302)) ([6c58d74](6c58d74))
* implemented  tracking on every share button ([#1328](#1328)) ([4c20717](4c20717))
* use repository recommendations from the API ([#1323](#1323)) ([aa8c33d](aa8c33d))
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

πŸŽ‰ This PR is included in version 1.55.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.55.0-beta.3](open-sauced/app@v1.55.0-beta.2...v1.55.0-beta.3) (2023-06-30)

### πŸ• Features

* use repository recommendations from the API ([#1323](open-sauced/app#1323)) ([aa8c33d](open-sauced/app@aa8c33d))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.55.0](open-sauced/app@v1.54.0...v1.55.0) (2023-07-06)

### πŸ› Bug Fixes

* adjust contributor distribution chart yscale max height ([#1329](open-sauced/app#1329)) ([0c6b176](open-sauced/app@0c6b176))
* hide unnecessary scrollbar in profilepage ([#1327](open-sauced/app#1327)) ([770f999](open-sauced/app@770f999))
* update author and license ([9a2c7de](open-sauced/app@9a2c7de))
* update DevCard component first contribution date format ([#1322](open-sauced/app#1322)) ([951945c](open-sauced/app@951945c))
* update DevCard Contribution term to Repo ([#1321](open-sauced/app#1321)) ([bc0d0cf](open-sauced/app@bc0d0cf))

### πŸ• Features

* add  `UserCard` to feeds page ([#1326](open-sauced/app#1326)) ([b225eb3](open-sauced/app@b225eb3))
* add `NewsletterForm` component to design system ([#1311](open-sauced/app#1311)) ([52573fb](open-sauced/app@52573fb))
* Hookup devcard page to real data ([#1302](open-sauced/app#1302)) ([6c58d74](open-sauced/app@6c58d74))
* implemented  tracking on every share button ([#1328](open-sauced/app#1328)) ([4c20717](open-sauced/app@4c20717))
* use repository recommendations from the API ([#1323](open-sauced/app#1323)) ([aa8c33d](open-sauced/app@aa8c33d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Recommended Repos are undefined
2 participants