feat: Create Reports Filter Component #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…of filters that will be mapped in the component.
…ort with created Atoms.
…pdated story to actually say Select Reports Filter.
…lated filter list.
bdougie
reviewed
Aug 16, 2022
bdougie
reviewed
Aug 16, 2022
bdougie
requested changes
Aug 16, 2022
We still use the Supabase UI library for a lot of our atoms. We import the component and then add a wrapper around it so we can add whatever we need and still have access to the component's APIs. Whenever I create an atom, I try to differentiate it what is coming from Supabase from what we're using by that naming convention. |
0-vortex
approved these changes
Aug 16, 2022
bdougie
approved these changes
Aug 17, 2022
|
🎉 This PR is included in version 1.2.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2022
## [1.2.0](v1.1.3...v1.2.0) (2022-08-20) ### 🍕 Features * **data:** adds live repo data and SWR ([#198](#198)) ([b6d80c3](b6d80c3)), closes [#191](#191) [#191](#191) [#206](#206) [#206](#206) * Create Reports Filter Component ([#207](#207)) ([efced23](efced23)), closes [#166](#166) * eChart for Contributors Component ([#216](#216)) ([7d5837b](7d5837b)), closes [#221](#221) [#213](#213) [#221](#221) * Implement Card Profile Component ([#232](#232)) ([efae3c5](efae3c5)) * Implement Card Repo List component ([#234](#234)) ([4a58eea](4a58eea)) ### 🧑💻 Code Refactoring * Add another version of the logo in the design system ([#236](#236)) ([f25b3a5](f25b3a5)) * Move Dashboard and Repositories into their own component ([#228](#228)) ([8b40fd8](8b40fd8)), closes [#208](#208) [#201](#201) [#202](#202) * replace context-filter-option with radio component ([41ed2b3](41ed2b3)) ### 🐛 Bug Fixes * **bug:** add require props ([#239](#239)) ([b9f0942](b9f0942)) * added Radio and SuperlativeSelector component stories ([06d956c](06d956c)) * eslint errors ([c191e26](c191e26)) * Removed gap from navbar and tools display ([#206](#206)) ([a3de620](a3de620))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.2.0-beta.1](open-sauced/app@v1.1.3-beta.3...v1.2.0-beta.1) (2022-08-17) ### 🍕 Features * Create Reports Filter Component ([#207](open-sauced/app#207)) ([efced23](open-sauced/app@efced23)), closes [#166](open-sauced/app#166)
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.2.0](open-sauced/app@v1.1.3...v1.2.0) (2022-08-20) ### 🍕 Features * **data:** adds live repo data and SWR ([#198](open-sauced/app#198)) ([b6d80c3](open-sauced/app@b6d80c3)), closes [#191](open-sauced/app#191) [#191](open-sauced/app#191) [#206](open-sauced/app#206) [#206](open-sauced/app#206) * Create Reports Filter Component ([#207](open-sauced/app#207)) ([efced23](open-sauced/app@efced23)), closes [#166](open-sauced/app#166) * eChart for Contributors Component ([#216](open-sauced/app#216)) ([7d5837b](open-sauced/app@7d5837b)), closes [#221](open-sauced/app#221) [#213](open-sauced/app#213) [#221](open-sauced/app#221) * Implement Card Profile Component ([#232](open-sauced/app#232)) ([efae3c5](open-sauced/app@efae3c5)) * Implement Card Repo List component ([#234](open-sauced/app#234)) ([4a58eea](open-sauced/app@4a58eea)) ### 🧑💻 Code Refactoring * Add another version of the logo in the design system ([#236](open-sauced/app#236)) ([f25b3a5](open-sauced/app@f25b3a5)) * Move Dashboard and Repositories into their own component ([#228](open-sauced/app#228)) ([8b40fd8](open-sauced/app@8b40fd8)), closes [#208](open-sauced/app#208) [#201](open-sauced/app#201) [#202](open-sauced/app#202) * replace context-filter-option with radio component ([41ed2b3](open-sauced/app@41ed2b3)) ### 🐛 Bug Fixes * **bug:** add require props ([#239](open-sauced/app#239)) ([b9f0942](open-sauced/app@b9f0942)) * added Radio and SuperlativeSelector component stories ([06d956c](open-sauced/app@06d956c)) * eslint errors ([c191e26](open-sauced/app@c191e26)) * Removed gap from navbar and tools display ([#206](open-sauced/app#206)) ([a3de620](open-sauced/app@a3de620))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the feature of the reports filter.
Details:
Created two atoms, Select and Select Option for the select drop down as well as a story for the select component. These filters are used in the created SelectReportsFilter component. The SelectReportsFilter takes an array of filterOption objects and a callback that accepts the value from the select dropdown option. The intention of the callback is that the person who uses the SelectReportsFilter (the reports page in the future) can get access to the selected value to leverage in any business logic.
Related Tickets & Documents
Fixes #166
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?