-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add @Lor1138 as a contributor #276
Conversation
Thank you for the opportunity to flex my open source muscles! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Lor1138,
Thanks for the PR! β¨
This is not a blocker, but can you please fill in the description in the PR form?
For your future reference, completing the PR form is necessary for maintainers to understand the changes you made and it can streamline the review process.
Thank you! π
What else should I put into the description? I followed the directions. hmmm |
Put "This PR adds [insert your name here] to the guestbook" @Lor1138. |
Hey @Lor1138, Understanding and filling in PR templates is more tricky than issues because they only allows to be shown in the format of Markdown instead of form as in issues. π Here are the tips that I hope can help you in the future! When looking at a PR template:
Another tips:
I hope this helps! Feel free to reach out to me if you have any question or need help! π |
Thank you for the detailed instructions! I figured it out, I really appreciate the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Lor1138,
We've helped you resolve the merge conflicts in your PR. β¨
Check out this section about how to resolve conflicts for your future reference.
If you haven't, you can join our community Discord. π
Also, check out our pizza-verse repo if you want to contribute further! π
Description
This PR adds Lor1138 to the guestbook
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section.
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?
<iframe src="https://giphy.com/embed/hZj44bR9FVI3K" width="396" height="480" frameBorder="0" class="giphy-embed" allowFullScreen></iframe>via GIPHY