Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add end to end testing framework #395

Closed
2 tasks done
bdougie opened this issue Nov 7, 2022 · 3 comments · Fixed by #396
Closed
2 tasks done

Feature: Add end to end testing framework #395

bdougie opened this issue Nov 7, 2022 · 3 comments · Fixed by #396
Assignees
@Deadreyo
Labels
💡 feature released on @beta released
Milestone
Working Submissio...

Comments

@bdougie
Copy link
Member

bdougie commented Nov 7, 2022

Type of feature

✅ Test

Current behavior

There are currently zero end to end test in this app and they are needed to start capturing some of the issues in the app.

Suggested solution

Can we explore the following and make a decision on the best framework moving forward?

Example tests to ship.

  • As a user, I should be able to log in
  • As a user, I should not be able to vote with out being logged in.

Additional context

This issue should be only be adding the test framework and one test. Please do not add the whole test suite.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added this to the Working Submissions and WAU milestone Nov 7, 2022
@mtfoley
Copy link
Contributor

mtfoley commented Nov 7, 2022

I’d give playwright a +1 for what that’s worth. I’ve done some stuff with it in my day job and I like it so far. Also I think the newer versions might have some good stuff with respect to being better with react apps (getting “testing library” style locators). https://playwright.dev/docs/release-notes#version-127

@Deadreyo Deadreyo mentioned this issue Nov 10, 2022
Merged
19 tasks
bdougie pushed a commit that referenced this issue Nov 14, 2022
@Deadreyo
feat: End-to-End testing setup (#396)
4533edd 
closes #395
github-actions bot pushed a commit that referenced this issue Nov 14, 2022
@Deadreyo @open-sauced
chore(minor): release 2.28.0-beta.1 on beta channel [skip ci]
62db8c4 
## [2.28.0-beta.1](v2.27.0...v2.28.0-beta.1) (2022-11-14)

### 🍕 Features

* End-to-End testing setup ([#396](#396)) ([4533edd](4533edd)), closes [#395](#395)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.28.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Dec 2, 2022
@bdougie @open-sauced
chore(minor): release 2.28.0 [skip ci]
78309c2 
## [2.28.0](v2.27.0...v2.28.0) (2022-12-02)

### 🍕 Features

* add my votes page placeholder and textual explanation ([#406](#406)) ([c2888dc](c2888dc)), closes [#208](#208)
* adds links for hot topic insights ([#398](#398)) ([19b367c](19b367c))
* End-to-End testing setup ([#396](#396)) ([4533edd](4533edd)), closes [#395](#395)
* Sort recent repos by votes ([#419](#419)) ([7116eeb](7116eeb)), closes [#399](#399)
* working repo submit button ([#408](#408)) ([ef17c2c](ef17c2c)), closes [#352](#352)

### 🐛 Bug Fixes

* unwanted drop shadow to the right side of the hero section. ([#402](#402)) ([62f3570](62f3570)), closes [#227](#227)
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

🎉 This issue has been resolved in version 2.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jan 2, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deadreyo Deadreyo

Labels
💡 feature released on @beta released
Projects
None yet
Milestone
Working Submissions and WAU
Development

Successfully merging a pull request may close this issue.

feat: End-to-End testing setup Deadreyo/hot.opensauce.pizza
3 participants
@mtfoley @bdougie @Deadreyo